Skip to content

Improve readability in RedisQueryCreator #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

junghoon-vans
Copy link
Contributor

Removed unnecessary code snippets on RedisQueryCreator.

In particular, query.getCriteria() is an unnecessary behavior.
Using the criteria passed as method arguments as-is will keep our code clean.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 29, 2023
@mp911de mp911de self-assigned this Sep 9, 2024
@mp911de mp911de changed the title Simplify logic in RedisQueryCreator. Improve readability in RedisQueryCreator Sep 10, 2024
@mp911de mp911de added the type: task A general task label Sep 10, 2024
@mp911de mp911de added this to the 3.3.4 (2024.0.4) milestone Sep 10, 2024
@mp911de
Copy link
Member

mp911de commented Sep 10, 2024

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Sep 10, 2024
@mp911de mp911de removed the status: waiting-for-triage An issue we've not yet triaged label Sep 10, 2024
mp911de pushed a commit that referenced this pull request Sep 10, 2024
mp911de added a commit that referenced this pull request Sep 10, 2024
Improve pattern variable naming, use ClassUtils.getDescriptiveType(…) to avoid null-pointer exceptions. Simplify RedisOperationChain condition checks.

See #2788
mp911de pushed a commit that referenced this pull request Sep 10, 2024
mp911de added a commit that referenced this pull request Sep 10, 2024
Improve pattern variable naming, use ClassUtils.getDescriptiveType(…) to avoid null-pointer exceptions. Simplify RedisOperationChain condition checks.

See #2788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants