DATAREDIS-531 - Fix deferred ScanCursor command execution using Jedis. #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection. Prepare issue branch.
Previously, ScanCursor held a reference to the Jedis connection which was used during ScanCursor creation. Cursors can be used outside RedisTemplate that leads to releasing/closing the initial connection. The retained reference used a released connection. We now check whether the connection is still open. If so, we reuse the connection. If the connection is closed, we use the associated connection factory to obtain a connection to invoke SCAN and release the reference after command execution.
|
Superseded by #218. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
ScanCursorheld a reference to the Jedis connection which was used during ScanCursor creation. Cursors can be used outside RedisTemplate that leads to releasing/closing the initial connection. The retained reference used a released connection.We now check whether the connection is still open. If so, we reuse the connection. If the connection is closed, we use the associated connection factory to obtain a connection to invoke
SCANand release the reference after command execution.Related ticket: DATAREDIS-531