Skip to content

Use Jedis SetParams.KEEPTTL instead of injecting byte[] args #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Feb 27, 2021

Currently jedis already support KEEPTTL command. So we optimize the convert code.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 27, 2021
@mp911de mp911de changed the title Optimize Jedis KEEPTTL command parameter convert Use Jedis SetParams.KEEPTTL instead of injecting byte[] args Mar 3, 2021
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 3, 2021
@mp911de mp911de added this to the 2.5 RC1 (2021.0.0) milestone Mar 3, 2021
@mp911de mp911de closed this in cf2cce8 Mar 3, 2021
@mp911de
Copy link
Member

mp911de commented Mar 3, 2021

Thank you for your contribution. That's merged now.

@dengliming dengliming deleted the jedis_keepttl branch March 3, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants