DATAREDIS-507 - Do not destroy RedisConnectionFactory in RedisKeyValueAdapter.destroy. #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory.destroy. Prepare issue branch.
…eAdapter.destroy. Do not destroy RedisConnectionFactory which is likely managed outside of RedisKeyValueAdapter. This change also retains a working connection factory while shutting down message listeners as those try to unsubscribe on shutdown.
christophstrobl
pushed a commit
that referenced
this pull request
May 4, 2016
…eAdapter.destroy. Do not destroy RedisConnectionFactory which is likely managed outside of RedisKeyValueAdapter. This change makes sure to retain a working connection factory while shutting down message listeners as those try to unsubscribe on shutdown. Original Pull Request: #195
christophstrobl
added a commit
that referenced
this pull request
May 4, 2016
Added missing author and issue reference. Original Pull Request: #195
christophstrobl
pushed a commit
that referenced
this pull request
May 4, 2016
…eAdapter.destroy. Do not destroy RedisConnectionFactory which is likely managed outside of RedisKeyValueAdapter. This change makes sure to retain a working connection factory while shutting down message listeners as those try to unsubscribe on shutdown. Original Pull Request: #195
christophstrobl
added a commit
that referenced
this pull request
May 4, 2016
Added missing author and issue reference. Original Pull Request: #195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not destroy
RedisConnectionFactorywhich is likely managed outside ofRedisKeyValueAdapter. This change also retains a working connection factory while shutting down message listeners as those try to unsubscribe on shutdown.Related ticket: DATAREDIS-507