DATAREDIS-427 - Allow construction of customized JdkSerializationRedisSerializer. #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sSerializer. Prepare issue branch.
…sSerializer. We now allow constructing JdkSerializationRedisSerializer using an own class loader and by specifying custom converters. Using an own class-loader: new JdkSerializationRedisSerializer(classLoader) Using own converters (Serializer/Deserializer): new JdkSerializationRedisSerializer(new SerializingConverter(), new DeserializingConverter(new DefaultDeserializer(classLoader)))
|
@rwinch Do you want to take also a look on this? |
|
@mp911de Thanks for sending this for my review! Out of curiosity what is the minimum Spring version that is supported? |
|
@rwinch You require at least 4.2.1 for this particular feature. With the Hopper release train, we require at least 4.2. |
|
@mp911de Ok I just wanted to make sure you were aware the constructor wasn't added till 4.2.1. +1 from me |
christophstrobl
pushed a commit
that referenced
this pull request
Mar 17, 2016
…sSerializer. We now allow constructing JdkSerializationRedisSerializer using an own class loader and by specifying custom converters. Using an own class-loader: new JdkSerializationRedisSerializer(classLoader) Using own converters (Serializer/Deserializer): new JdkSerializationRedisSerializer(new SerializingConverter(), new DeserializingConverter(new DefaultDeserializer(classLoader))) Original Pull Request: #179
christophstrobl
added a commit
that referenced
this pull request
Mar 17, 2016
Use ShadowingClassLoader instead of a self written one. Original Pull Request: #179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow constructing JdkSerializationRedisSerializer using an own class loader and by specifying custom converters.
Using an own class-loader:
new JdkSerializationRedisSerializer(classLoader)Using own serializers:
new JdkSerializationRedisSerializer(new SerializingConverter(), new DeserializingConverter(new DefaultDeserializer(classLoader)))Related ticket: DATAREDIS-427