DATAREDIS-348 - Switch to mp911de/lettuce 3.0. #144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
|
Can't wait to see this hit! |
|
It's hopefully in the Gosling release train. @christophstrobl @olivergierke any updates? |
Prepare issue branch.
- Update lettuce redis client to latest snapshot, adopt changed API and use API for commands which were emulated using LUA script - Implement Sentinel support using lettuce library, adopt finer grained exceptions and aligned exception behavior to match other libraries. Added shutdown-timeout property in order to control shutdown duration of the netty framework which reduces test run duration. Documentation updated as well. Contains also a fix to use psetex instead of setex (typo). - Switch to Jedis for Redis Version discovery in tests - Polishing of documentation - Use LettuceConverter and native time() method
- Fix conneciton problems leaving sockets open. - Add missing JUnit rules for Sentinels. - Add missing author information update,license header, javadoc. - Upgrade test script to use redis 3.0.2. - Upgrade test script to shut down redis in case of test errors. - Add redis 3.0 to TestProfileValueSource. - Enable ZRANGEBYLEX tests for lettuce.
christophstrobl
force-pushed
the
issue/DATAREDIS-348
branch
from
8cca5d7 to
bd94849
Compare
odrotbohm
pushed a commit
that referenced
this pull request
Aug 4, 2015
Updated lettuce redis client to latest snapshot, adopt changed API and use API for commands which were emulated using LUA script Implemente Sentinel support using lettuce library, adopt finer grained exceptions and aligned exception behavior to match other libraries. Added shutdown-timeout property in order to control shutdown duration of the netty framework which reduces test run duration. Documentation updated as well. Contains also a fix to use psetex instead of setex (typo). Switch to Jedis for Redis Version discovery in tests. Polished documentation. Use LettuceConverter and native time() method. Original pull request: #144. Related pull request: #104.
christophstrobl
added a commit
that referenced
this pull request
Aug 4, 2015
Fixed connection problems leaving sockets open. Added missing JUnit rules for Sentinels. Added missing author information update, license header and Javadoc. Upgraded test script to use Redis 3.0.2. Upgrade test script to shut down Redis in case of test errors. Added Redis 3.0 to TestProfileValueSource. Enabled ZRANGEBYLEX tests for lettuce. Original pull request: #144. Related pull request: #104.
|
Many thanks to you. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick up mp911de/lettuce including Sentinel support. Cluster support will be treated in another issues.
This PR supersedes #104 and has been opend in order to double check details with the team.
Thanks @mp911de for the hard work!