Skip to content

Add NOMKSTREAM option to XADD command #2047

Closed
@mp911de

Description

@mp911de

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general ideal-for-contribution issues. Thanks!

Problem

Redis 6.2 introduced a new flag, NOMKSTREAM to its XADD command. We want to support this flag in Spring Data Redis.

Solution

We have XAddOptions as a collector for additional arguments for the XADD command. Extend XAddOptions (for the imperative API) and AddStreamRecord (for the reactive API). Add tests to verify this functionality.

See also https://redis.io/commands/xadd for further information.

Steps to Fix

  • Claim this issue with a comment below and ask any clarifying questions you need
  • Set up a repository locally following the Contributing Guidelines
  • Try to fix the issue following the steps above
  • Commit your changes and start a pull request

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions