RedisTemplate's default serializer assumes that its ClassLoader can load application types [DATAREDIS-501]

[spring-projects-issues]

Andy Wilkinson opened DATAREDIS-501 and commented

By default, RedisTemplate uses a JdkSerializationRedisSerializer that will use the default class loader (typically the app class loader) for deserialization. This assumes that the class loader that loaded RedisTemplate will also be able to load an application's own classes. This doesn't hold true when using Spring Boot's DevTools or in a container where Spring Data Redis is installed as a shared library.

DATAREDIS-427 made it easier to configure the class loader used by JdkSerializationRedisSerializer. Could RedisTemplate be updated to take advantage of this and configure its default JdkSerializationRedisSerializer to use the application context's ClassLoader?

---

Affects: 1.7.1 (Hopper SR1)

Reference URL: spring-projects/spring-boot#5760

Referenced from: pull request #192, and commits 0f8969f, 79b4028, f5ecd3a, 97da377, a3bd816

Backported to: 1.7.2 (Hopper SR2)

[spring-projects-issues]

Christoph Strobl commented

thanks Andy Wilkinson for reporting - we'll take care of that

[spring-projects-issues]

Andy Wilkinson commented

use the application context's ClassLoader

Was a bit ambiguous. To be more precise, I am suggesting that the ClassLoader that's available from either ResourceLoader.getClassLoader or ConfigurableBeanFactory.getClassLoader. The latter is probably the more appropriate of the two

[spring-projects-issues]

Christoph Strobl commented

in case ResourceLoader.getClassLoader is sufficient we could make RedisTemplate ResourceLoaderAware. Since it is already an InitializingBean we'd be able to pick up the ClassLoader in afterPropertiesSet and pass it on to the JdkSerializationRedisSerializer

[spring-projects-issues]

Andy Wilkinson commented

I think that would work. More than happy to try a snapshot when one is available

[spring-projects-issues]

Christoph Strobl commented

snapshot build for version 1.8.0.DATAREDIS-501-SNAPSHOT already available.

[spring-projects-issues]

Andy Wilkinson commented

Thanks, Christoph. I've just tested it and it works as hoped. Can the fix be included in Hopper SR2 please?

[spring-projects-issues]

Oliver Drotbohm commented

Any reason we're not implementing BeanClassLoaderAware as it's the most minimal interface that we could use to express what we actually need?

[spring-projects-issues]

Andy Wilkinson commented

Sounds like a good option to me. As I said above, using the bean class loader is the ideal here

[spring-projects-issues]

Christoph Strobl commented

just my ignorance - updated branch - snapshots should be available shortly