DATAMONGO-2652 - Implements deleteAllById. #892
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
requested changes
Nov 19, 2020
|
|
||
| Assert.notNull(ids, "The given Iterable of ids must not be null!"); | ||
|
|
||
| return Flux.fromIterable(ids).flatMap(this::deleteById).then(); |
There was a problem hiding this comment.
We should collect all ID's into a query to run a single delete query and to avoid issuing a query per given Id.
There was a problem hiding this comment.
Should we do the same for public Mono<Void> deleteAll(Iterable<? extends T> entities)?
There was a problem hiding this comment.
I made the same change for public Mono<Void> deleteAll(Iterable<? extends T> entities) as well in a separate commit.
Pick and choose.
mp911de
approved these changes
Nov 25, 2020
|
|
||
| Assert.notNull(ids, "The given Iterable of ids must not be null!"); | ||
|
|
||
| ids.forEach(this::deleteById); |
There was a problem hiding this comment.
We should use a single query here. Going to apply that change during the merge.
mp911de
pushed a commit
that referenced
this pull request
Nov 25, 2020
….delete(Iterable<ID> ids). See also: DATACMNS-800. Original pull request: #892.
mp911de
added a commit
that referenced
this pull request
Nov 25, 2020
Reorder implementation methods. Reduce visibility of test methods according to JUnit 5 requirements. Original pull request: #892.
mp911de
added a commit
that referenced
this pull request
Nov 25, 2020
Reorder implementation methods. Reduce visibility of test methods according to JUnit 5 requirements. Original pull request: #892.
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after DATACMNS-800