DATAMONGO-2392 - Fix handling of old GridFS files with custom type fo… #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickstolwijk Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@nickstolwijk Thank you for signing the Contributor License Agreement! |
mp911de
pushed a commit
that referenced
this pull request
Oct 16, 2019
…es with custom id type. Original pull request: #796.
mp911de
added a commit
that referenced
this pull request
Oct 16, 2019
We now consistently use GridFSFile.getId() to allow custom Id usage instead of enforcing the Id to be an ObjectId. Using the native Id allows interaction with files that use a custom Id type. Original pull request: #796.
mp911de
added a commit
that referenced
this pull request
Oct 16, 2019
Add author tags. Move integration tests to existing test class. Apply more appropriate in existing tests assertions. Use diamond syntax. Original pull request: #796.
mp911de
pushed a commit
that referenced
this pull request
Oct 16, 2019
…es with custom id type. Original pull request: #796.
mp911de
added a commit
that referenced
this pull request
Oct 16, 2019
We now consistently use GridFSFile.getId() to allow custom Id usage instead of enforcing the Id to be an ObjectId. Using the native Id allows interaction with files that use a custom Id type. Original pull request: #796.
mp911de
added a commit
that referenced
this pull request
Oct 16, 2019
Add author tags. Move integration tests to existing test class. Apply more appropriate in existing tests assertions. Use diamond syntax. Original pull request: #796.
|
Thanks a lot. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DATAMONGO-2392 - Fix handling of old GridFS files with custom type for _id field.