Skip to content

DATAMONGO-2228 - Fixed loosing branches in AND expressions (MongodbDo… #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MikhailKaduchka
Copy link
Contributor

@MikhailKaduchka MikhailKaduchka commented Mar 14, 2019

…cumentSerializer)

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@gregturn
Copy link
Contributor

This PR needs to be rebased against the latest master branch. It is clearly missing the ci folder which contains the test scripts, etc. needed by the CI server.

@MikhailKaduchka MikhailKaduchka force-pushed the bugfix/mongo-document-serializer branch from f3c744f to 4acc473 Compare March 14, 2019 07:10
@MikhailKaduchka
Copy link
Contributor Author

This PR needs to be rebased against the latest master branch. It is clearly missing the ci folder which contains the test scripts, etc. needed by the CI server.

Hello Greg, could explain a bit more what do you mean?
As I can see it's synced with master and has ci folder (https://github.com/MikhailKaduchka/spring-data-mongodb/tree/bugfix/mongo-document-serializer)

christophstrobl pushed a commit that referenced this pull request Mar 18, 2019
christophstrobl added a commit that referenced this pull request Mar 18, 2019
Favor AssertJ over hamcrest.

Original Pull Request: #661
christophstrobl pushed a commit that referenced this pull request Mar 18, 2019
christophstrobl added a commit that referenced this pull request Mar 18, 2019
Favor AssertJ over hamcrest.

Original Pull Request: #661
@christophstrobl
Copy link
Member

Thank you @MikhailKaduchka. Changes are now on master (cd930ea) and have been back ported to 2.1.x (5517198).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants