DATAMONGO-2195 - Consider version when removing an entity. #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e operations. We now make sure to apply the WriteConcern correctly when calling deleteOne on MongoCollection.
We now consider a potential @Version when removing an entity. MongoOperations#remove(Object) and MongoOperations#remove(Object, String) new throw an OptimisticLockingFailureException when the object to remove is versioned and the version of the given entity does not match the one within the store. If no document with matching _id can be found the remove operation passes without an error. MongoRepository now also considers the entities version, following the very same logic as MongoOperations. To remove an entity without version check use MongoOperations#remove(Query,…) or MongoRepository#deleteById(…
odrotbohm
requested changes
Feb 4, 2019
|
|
||
| }).flatMap(deleteResult -> { | ||
|
|
||
| if (entity != null && entity.hasVersionProperty()) { |
There was a problem hiding this comment.
Please invert the if clauses to use early returns to avoid the heavy nesting.
| */ | ||
| default Query getRemoveByQuery() { | ||
|
|
||
| if (isVersionedEntity()) { |
And guard transaction tests.
christophstrobl
force-pushed
the
issue/DATAMONGO-2195
branch
from
7bf6503 to
777d478
Compare
…ly in repositories. OptimisticLockingFailureException is now thrown only when deleting an entity through a repository and no longer when using the Template API.
mp911de
pushed a commit
that referenced
this pull request
Feb 7, 2019
…e operations. We now make sure to apply the WriteConcern correctly when calling deleteOne on MongoCollection. Original pull request: #641.
mp911de
pushed a commit
that referenced
this pull request
Feb 7, 2019
We now consider a potential @Version when removing an entity. MongoOperations#remove(Object) and MongoOperations#remove(Object, String) include the version of the object to remove if the entity is versioned. Opposed to save(Object), remove(Object) does not throw OptimisticLockingFailureException if a versioned entity could not be removed. This behavior is subject to be changed in a future release. Throwing OptimisticLockingFailureException on failed delete on Template API level was not introduced to not break existing application code. MongoRepository now also considers the entities version, following the very same logic as MongoOperations. To remove an entity without version check use MongoOperations#remove(Query,…) or MongoRepository#deleteById(…). Original pull request: #641.
mp911de
added a commit
that referenced
this pull request
Feb 7, 2019
…ly in repositories. OptimisticLockingFailureException is now thrown only when deleting an entity through a repository and no longer when using the Template API. Original pull request: #641.
mp911de
pushed a commit
that referenced
this pull request
Feb 7, 2019
…e operations. We now make sure to apply the WriteConcern correctly when calling deleteOne on MongoCollection. Original pull request: #641.
|
That's merged, polished and partially backported now. |
mp911de
added a commit
that referenced
this pull request
Feb 12, 2019
Fix stubbing in test that sneaked in through a back port not considering the change which method was used for entity removal. Original pull request: #641.
This was referenced Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now consider a potential
@Versionwhen removing an entity.MongoOperations#remove(Object)andMongoOperations#remove(Object, String)now throw anOptimisticLockingFailureExceptionwhen the object to remove is versioned and the version of the given entity does not match the one within the store. If no document with matching_idcan be found the remove operation passes without an error. Same applies to remove operations executed inside an ongoing MongoDB transaction.MongoRepositorynow also considers the entities version, following the very same logic asMongoOperations.To remove an entity without version check use
MongoOperations#remove(Query,…)orMongoRepository#deleteById(…This PR also includes a fix (2nd commit) for DATAMONGO-2196 that should be back ported to 2.1.x and 2.0.x.