Skip to content

Pass on FullDocumentBeforeChange option to change stream iterable/publisher. #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

This PR ensures to pass on a potentially set FullDocumentBeforeChange option to the change stream iterable/publisher.
It also corrects false optional behaviour within the ChangeStreamTask which did some defaulting though the actual value is an optional one that must not be present.

Closes: #4495

…lisher.

This commit ensures to pass on a potentially set FullDocumentBeforeChange option to the change stream iterable/publisher.
It also corrects false optional behaviour within the change stream task which did some defaulting though the actual value is an optional one that must not be present.
mp911de pushed a commit that referenced this pull request Nov 2, 2023
…lisher.

This commit ensures to pass on a potentially set FullDocumentBeforeChange option to the change stream iterable/publisher.
It also corrects false optional behavior within the change stream task which did some defaulting though the actual value is an optional one that must not be present.

Original pull request: #4541
Closes #4495
mp911de added a commit that referenced this pull request Nov 2, 2023
Reformat code. Suppress warnings in tests.

Original pull request: #4541
See #4495
mp911de pushed a commit that referenced this pull request Nov 2, 2023
…lisher.

This commit ensures to pass on a potentially set FullDocumentBeforeChange option to the change stream iterable/publisher.
It also corrects false optional behavior within the change stream task which did some defaulting though the actual value is an optional one that must not be present.

Original pull request: #4541
Closes #4495
mp911de added a commit that referenced this pull request Nov 2, 2023
Reformat code. Suppress warnings in tests.

Original pull request: #4541
See #4495
mp911de pushed a commit that referenced this pull request Nov 2, 2023
…lisher.

This commit ensures to pass on a potentially set FullDocumentBeforeChange option to the change stream iterable/publisher.
It also corrects false optional behavior within the change stream task which did some defaulting though the actual value is an optional one that must not be present.

Original pull request: #4541
Closes #4495
mp911de added a commit that referenced this pull request Nov 2, 2023
Reformat code. Suppress warnings in tests.

Original pull request: #4541
See #4495
@mp911de mp911de added this to the 4.0.12 (2022.0.12) milestone Nov 2, 2023
@mp911de
Copy link
Member

mp911de commented Nov 2, 2023

That's merged, polished, and backported now.

@mp911de mp911de closed this Nov 2, 2023
@mp911de mp911de deleted the issue/4495 branch November 2, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReactiveMongoTemplate does not return ChangeStreamEvents with PreImages
2 participants