Skip to content

DATAMONGO-1325 Add support for $sample to aggregation. #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
* @author Alessio Fachechi
* @author Christoph Strobl
* @author Nikolay Bogdanov
* @author Gustavo de Geus
* @since 1.3
*/
public class Aggregation {
Expand Down Expand Up @@ -384,6 +385,16 @@ public static LimitOperation limit(long maxElements) {
return new LimitOperation(maxElements);
}

/**
* Creates a new {@link SampleOperation} to selects the specified number of documents from its input randomly.
*
* @param sampleSize must not be less than zero.
* @return
*/
public static SampleOperation sample(long sampleSize) {
return new SampleOperation(sampleSize);
}

/**
* Creates a new {@link MatchOperation} using the given {@link Criteria}.
*
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/*
* Copyright 2013-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.data.mongodb.core.aggregation;

import org.springframework.util.Assert;

import com.mongodb.BasicDBObject;
import com.mongodb.DBObject;

/**
* Encapsulates the {@code $sample}-operation.
* <p>
* We recommend to use the static factory method {@link Aggregation#sample(long)} instead of creating instances of this
* class directly.
*
* @author Gustavo de Geus
* @since 2.0
* @see <a href="https://docs.mongodb.com/master/reference/operator/aggregation/sample/">MongoDB Aggregation Framework: $sample</a>
*/
public class SampleOperation implements AggregationOperation {

private final long sampleSize;

/**
* @param sampleSize number of documents to be randomly selected from its input.
*/
public SampleOperation(long sampleSize) {

Assert.isTrue(sampleSize > 0, "Sample size must be greater than zero!");
this.sampleSize = sampleSize;
}

/*
* (non-Javadoc)
* @see org.springframework.data.mongodb.core.aggregation.AggregationOperation#toDBObject(org.springframework.data.mongodb.core.aggregation.AggregationOperationContext)
*/
@Override
public DBObject toDBObject(AggregationOperationContext context) {
return new BasicDBObject("$sample", new BasicDBObject("size", this.sampleSize));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
/*
* Copyright 2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.data.mongodb.core.aggregation;

import static org.hamcrest.CoreMatchers.*;
import static org.junit.Assert.*;

import org.junit.Test;

import com.mongodb.BasicDBObject;
import com.mongodb.DBObject;

/**
* Unit tests for {@link SampleOperation}.
*
* @author Gustavo de Geus
*/
public class SampleOperationUnitTests {

private static final String SIZE = "size";
private static final String OP = "$sample";

@Test(expected = IllegalArgumentException.class)
public void rejectsNegativeSample() {
new SampleOperation(-1L);
}

@Test(expected = IllegalArgumentException.class)
public void rejectsZeroSample() {
new SampleOperation(0L);
}

@Test
public void rendersSampleOperation() {
long sampleSize = 5L;
SampleOperation sampleOperation = Aggregation.sample(sampleSize);
DBObject sampleOperationDbObject = sampleOperation.toDBObject(Aggregation.DEFAULT_CONTEXT);
assertNotNull(sampleOperationDbObject.get(OP));
assertThat(sampleOperationDbObject.get(OP), is(instanceOf(BasicDBObject.class)));
BasicDBObject sampleSizeDbObject = (BasicDBObject) sampleOperationDbObject.get(OP);
assertEquals(sampleSize, sampleSizeDbObject.get(SIZE));
}
}