DATAMONGO-1620 - Add server-selection-timeout to XML MongoClientOptions config. #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tOptions using MongoClientOptionsFactoryBean. Prepare issue branch.
…ns config. We now allow server-selection-timeout attribute on MongoClientOptions XML configuration for a MongoDB 3.x client.
Use Integer.MIN_VALUE as placeholder for unset values to allow setting zero (immediately) and -1 (indefinite wait) server selection timeouts.
mp911de
pushed a commit
that referenced
this pull request
Mar 13, 2017
…ns config. We now allow server-selection-timeout attribute on MongoClientOptions XML configuration for a MongoDB 3.x client. Original pull request: #449.
mp911de
added a commit
that referenced
this pull request
Mar 13, 2017
Fix test method name. Add JavaDoc. Original pull request: #449.
mp911de
pushed a commit
that referenced
this pull request
Mar 13, 2017
…ns config. We now allow server-selection-timeout attribute on MongoClientOptions XML configuration for a MongoDB 3.x client. Original pull request: #449.
mp911de
added a commit
that referenced
this pull request
Mar 13, 2017
Use Integer.MIN_VALUE as placeholder for unset values to allow setting zero (immediately) and -1 (indefinite wait) server selection timeouts. Fix test method name. Add JavaDoc. Original pull request: #449.
mp911de
pushed a commit
that referenced
this pull request
Mar 13, 2017
…ns config. We now allow server-selection-timeout attribute on MongoClientOptions XML configuration for a MongoDB 3.x client. Original pull request: #449.
mp911de
added a commit
that referenced
this pull request
Mar 13, 2017
Use Integer.MIN_VALUE as placeholder for unset values to allow setting zero (immediately) and -1 (indefinite wait) server selection timeouts. Fix test method name. Add JavaDoc. Original pull request: #449.
|
That's merged, polished and ported to the according branches. Removed reflection access for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows in combination with a MongoDB Java Driver
3.xsetting theserverSelectionTimeoutonMongoClientOptionsvia theserver-selection-timeoutXML attribute.The attribute is ignored when set using a
2.xMongoDB driver.This change should be ported to
1.10.x(the namespace xsd (1.10.2) is already set up for it).For
2.xtheserver-selection-timeoutshould be added leaving out the reflection fluff required inMongoClientOptionsFactoryBeanfor1.x.