DATAMONGO-1617 - IDs with non-autogeneratable type cannot be assigned automatically with custom event listeners #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
laszlocsontos
commented
Feb 22, 2017
laszlocsontos
commented
- You have read the Spring Data contribution guidelines.
- There is a ticket in the bug tracker for the project in our JIRA.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
|
@laszlocsontos Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@laszlocsontos Thank you for signing the Contributor License Agreement! |
odrotbohm
pushed a commit
that referenced
this pull request
Feb 28, 2017
…dendifier assertion. We now make sure the BeforeConvertEvent is published before we check for identifier types that can potentially be auto-generated. That allows the event listeners to populate identifiers. Previously the identifier check kicked in before that and thus caused the listener not being able to populate the property. Original pull request: #443.
odrotbohm
added a commit
that referenced
this pull request
Feb 28, 2017
Some cleanups in MongoTemplateTests. Removed manual ID assignment in general id handling test to make sure we use the id generation. Removed unneccessary code from domain type in favor of Lombok. Original pull request: #443.
odrotbohm
pushed a commit
that referenced
this pull request
Feb 28, 2017
…dendifier assertion. We now make sure the BeforeConvertEvent is published before we check for identifier types that can potentially be auto-generated. That allows the event listeners to populate identifiers. Previously the identifier check kicked in before that and thus caused the listener not being able to populate the property. Original pull request: #443.
odrotbohm
added a commit
that referenced
this pull request
Feb 28, 2017
Some cleanups in MongoTemplateTests. Removed manual ID assignment in general id handling test to make sure we use the id generation. Removed unneccessary code from domain type in favor of Lombok. Original pull request: #443.
odrotbohm
pushed a commit
that referenced
this pull request
Feb 28, 2017
…dendifier assertion. We now make sure the BeforeConvertEvent is published before we check for identifier types that can potentially be auto-generated. That allows the event listeners to populate identifiers. Previously the identifier check kicked in before that and thus caused the listener not being able to populate the property. Original pull request: #443.
odrotbohm
added a commit
that referenced
this pull request
Feb 28, 2017
Some cleanups in MongoTemplateTests. Removed manual ID assignment in general id handling test to make sure we use the id generation. Removed unneccessary code from domain type in favor of Lombok. Original pull request: #443.
|
That's merged, polished and merged. Forward port to 2.0 branch pending. |
odrotbohm
added a commit
that referenced
this pull request
Feb 28, 2017
Some cleanups in MongoTemplateTests. Removed manual ID assignment in general id handling test to make sure we use the id generation. Removed unneccessary code from domain type in favor of Lombok. Original pull request: #443.
odrotbohm
added a commit
that referenced
this pull request
Feb 28, 2017
… BeforeConvertEvent publication. Related pull request: #443.
odrotbohm
added a commit
that referenced
this pull request
Feb 28, 2017
… BeforeConvertEvent publication. Related pull request: #443.
odrotbohm
added a commit
that referenced
this pull request
Feb 28, 2017
… BeforeConvertEvent publication. Related pull request: #443.
christophstrobl
pushed a commit
that referenced
this pull request
Mar 3, 2017
…dendifier assertion. We now make sure the BeforeConvertEvent is published before we check for identifier types that can potentially be auto-generated. That allows the event listeners to populate identifiers. Previously the identifier check kicked in before that and thus caused the listener not being able to populate the property. Original pull request: #443.
christophstrobl
pushed a commit
that referenced
this pull request
Mar 3, 2017
Some cleanups in MongoTemplateTests. Removed manual ID assignment in general id handling test to make sure we use the id generation. Removed unneccessary code from domain type in favor of Lombok. Original pull request: #443.
christophstrobl
pushed a commit
that referenced
this pull request
Mar 3, 2017
… BeforeConvertEvent publication. Related pull request: #443.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.