DATAMONGO-1603 - Fix Placeholder not replaced correctly in @Query. #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare issue branch.
Fix issues when placeholders are appended with other chars eg. '?0xyz' or have been reused multiple times within the query.
Additional tests and fixes for complex quoted replacements eg. in regex query.
christophstrobl
force-pushed
the
issue/DATAMONGO-1603
branch
from
336e5bc to
052c057
Compare
Rely on Placeholder quotation indication instead of binding one. Might be misleading when placeholder is used more than once.
Remove code that became unused. Reformat code. Extend years in copyright header.
mp911de
pushed a commit
that referenced
this pull request
Mar 1, 2017
Fix issues when placeholders are appended with other chars eg. '?0xyz' or have been reused multiple times within the query. Additional tests and fixes for complex quoted replacements eg. in regex query. Rely on placeholder quotation indication instead of binding one. Might be misleading when placeholder is used more than once. Original pull request: #441.
mp911de
added a commit
that referenced
this pull request
Mar 1, 2017
Remove code that became unused. Reformat code. Extend years in copyright header. Original pull request: #441.
mp911de
pushed a commit
that referenced
this pull request
Mar 1, 2017
Fix issues when placeholders are appended with other chars eg. '?0xyz' or have been reused multiple times within the query. Additional tests and fixes for complex quoted replacements eg. in regex query. Rely on placeholder quotation indication instead of binding one. Might be misleading when placeholder is used more than once. Original pull request: #441.
mp911de
added a commit
that referenced
this pull request
Mar 1, 2017
Remove code that became unused. Reformat code. Extend years in copyright header. Original pull request: #441.
mp911de
pushed a commit
that referenced
this pull request
Mar 1, 2017
Fix issues when placeholders are appended with other chars eg. '?0xyz' or have been reused multiple times within the query. Additional tests and fixes for complex quoted replacements eg. in regex query. Rely on placeholder quotation indication instead of binding one. Might be misleading when placeholder is used more than once. Original pull request: #441.
mp911de
added a commit
that referenced
this pull request
Mar 1, 2017
Remove code that became unused. Reformat code. Extend years in copyright header. Original pull request: #441.
|
That's merged. |
mp911de
pushed a commit
that referenced
this pull request
Mar 1, 2017
Fix issues when placeholders are appended with other chars eg. '?0xyz' or have been reused multiple times within the query. Additional tests and fixes for complex quoted replacements eg. in regex query. Rely on placeholder quotation indication instead of binding one. Might be misleading when placeholder is used more than once. This backport contains elements from DATAMONGO-1575. Original pull request: #441. Related ticket: DATAMONGO-1575.
mp911de
added a commit
that referenced
this pull request
Mar 1, 2017
Remove code that became unused. Reformat code. Extend years in copyright header. Original pull request: #441.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues when placeholders are appended with other chars eg.
'?0xyz'or have been reused multiple times within the query.