DATAMONGO-1530 - Add support for missing aggregation operators in SpEL based support. #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare issue branch.
…line operators. Original Pull Request: #410
christophstrobl
force-pushed
the
issue/DATAMONGO-1530
branch
from
9a9315d to
481ce94
Compare
mp911de
reviewed
Nov 24, 2016
| */ | ||
| @lombok.Data | ||
| @lombok.Builder | ||
| public static class AggregationMethodReference { |
There was a problem hiding this comment.
How about an custom written builder that is not public and is tailored to the construction flow (i.e. method name always required, adoption of argument type characteristics)?
Add missing transformations for ConstructorReference, OperatorNot, OpNE, OpEQ, OpGT, OpGE, OpLT, OpLE, OperatorPower, OpOr and OpAnd. This allows usage of logical operators &, || and ! as part of the expression, while ConstructorReference allows instantiating eg. arrays via an expression `new int[]{4,5,6}`. This can be useful eg. comparing arrays using $setEquals.
More complex aggregation operators like $filter can be created by defining the variable references as string inside the expression like filter(a, 'num', '$$num' > 10).
Commands like $let requires usage of InlineMap to pass in required arguments like eg. let({low:1, high:'$$low'}, gt('$$low', '$$high')).
Original Pull Request: #410
christophstrobl
force-pushed
the
issue/DATAMONGO-1530
branch
from
481ce94 to
6252e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow usage of mostly all aggregation operation expressions via SpEL on pipeline stage.
Supersedes (and contains changes from): #410