Consistent log of CyclicPropertyReferenceException #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: DATAMONGO-1205
mp911de
pushed a commit
that referenced
this pull request
Apr 20, 2017
We log CyclicPropertyReferenceException with its message only and removed the stack trace from the log. The stacktrace points to a verifier location and is not particularly useful in finding the offending code. This change creates consistency over how CyclicPropertyReferenceException is logged. Original pull request: #397.
mp911de
added a commit
that referenced
this pull request
Apr 20, 2017
Add author tag. Extend year range in copyright header. Original pull request: #397.
mp911de
pushed a commit
that referenced
this pull request
Apr 20, 2017
We log CyclicPropertyReferenceException with its message only and removed the stack trace from the log. The stacktrace points to a verifier location and is not particularly useful in finding the offending code. This change creates consistency over how CyclicPropertyReferenceException is logged. Original pull request: #397.
mp911de
added a commit
that referenced
this pull request
Apr 20, 2017
Add author tag. Extend year range in copyright header. Original pull request: #397.
mp911de
pushed a commit
that referenced
this pull request
Apr 20, 2017
We log CyclicPropertyReferenceException with its message only and removed the stack trace from the log. The stacktrace points to a verifier location and is not particularly useful in finding the offending code. This change creates consistency over how CyclicPropertyReferenceException is logged. Original pull request: #397.
mp911de
added a commit
that referenced
this pull request
Apr 20, 2017
Add author tag. Extend year range in copyright header. Original pull request: #397.
mp911de
pushed a commit
that referenced
this pull request
Apr 20, 2017
We log CyclicPropertyReferenceException with its message only and removed the stack trace from the log. The stacktrace points to a verifier location and is not particularly useful in finding the offending code. This change creates consistency over how CyclicPropertyReferenceException is logged. Original pull request: #397.
mp911de
added a commit
that referenced
this pull request
Apr 20, 2017
Add author tag. Extend year range in copyright header. Original pull request: #397.
|
Thanks for your PR. That's merged and polished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: DATAMONGO-1205