Allow to estimate document count. #3951
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophstrobl
force-pushed
the
issue/3522
branch
from
360c223 to
925cdda
Compare
christophstrobl
force-pushed
the
issue/3522
branch
from
925cdda to
002bda7
Compare
mp911de
reviewed
Mar 4, 2022
...ata-mongodb/src/main/java/org/springframework/data/mongodb/core/ReactiveMongoOperations.java
Outdated
Show resolved
Hide resolved
spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoTemplate.java
Outdated
Show resolved
Hide resolved
| * @param entityClass class that determines the collection to use. Must not be {@literal null}. | ||
| * @return the count of matching documents. | ||
| */ | ||
| Mono<Long> count(Query query, Class<?> entityClass); |
There was a problem hiding this comment.
Nit: We should probably slim down the second documentation paragraph and link to both count methods via @see.
This commit introduce an option that allows users to opt in on using estimatedDocumentCount instead of countDocuments in case the used filter query is empty. To still be able to retrieve the precise number of matching documents we also introduced MongoTemplate#preciseCount.
christophstrobl
force-pushed
the
issue/3522
branch
from
002bda7 to
cee670f
Compare
mp911de
pushed a commit
that referenced
this pull request
Mar 11, 2022
This commit introduce an option that allows users to opt in on using estimatedDocumentCount instead of countDocuments in case the used filter query is empty. To still be able to retrieve the exact number of matching documents we also introduced MongoTemplate#exactCount. Closes: #3522 Original pull request: #3951.
mp911de
pushed a commit
that referenced
this pull request
Mar 11, 2022
This commit introduce an option that allows users to opt in on using estimatedDocumentCount instead of countDocuments in case the used filter query is empty. To still be able to retrieve the exact number of matching documents we also introduced MongoTemplate#exactCount. Closes: #3522 Original pull request: #3951.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an option that allows users to opt in on using
estimatedDocumentCountinstead ofcountDocumentsin case the used filter query is empty.