DATAMONGO-1490 - Change the XML data type of boolean flags to String. #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
changed the title
mp911de
force-pushed
the
issue/DATAMONGO-1490
branch
from
ef9ed99 to
f7a2458
Compare
Prepare issue branch.
We now accept String data types for boolean flags in XML configurations. Boolean data types in the XSD don't allows use of property placeholders even if the resolved value could be converted to boolean. Affected fields by this change are: * `<mongo:repositories create-query-indexes=… />` * `<mongo:options ssl=…/>` * `<mongo:client-options ssl=… />`
christophstrobl
force-pushed
the
issue/DATAMONGO-1490
branch
from
f7a2458 to
cfec65a
Compare
Restore 1.8.xsd and create new 1.10 one reflecting the changes made.
christophstrobl
force-pushed
the
issue/DATAMONGO-1490
branch
from
cfec65a to
685f144
Compare
mp911de
commented
Oct 20, 2016
| @@ -37,8 +37,8 @@ Defines a MongoClient instance used for accessing MongoDB. | |||
| <tool:annotation> | |||
There was a problem hiding this comment.
Let's remove changes to this file entirely from the PR.
christophstrobl
pushed a commit
that referenced
this pull request
Oct 24, 2016
We now accept String data types for boolean flags in XML configurations. Boolean data types in the XSD don't allows use of property placeholders even if the resolved value could be converted to boolean. Affected fields by this change are: * `<mongo:repositories create-query-indexes=… />` * `<mongo:options ssl=…/>` * `<mongo:client-options ssl=… />` Original Pull Request: #389
christophstrobl
pushed a commit
that referenced
this pull request
Oct 24, 2016
Original Pull Request: #389
christophstrobl
added a commit
that referenced
this pull request
Oct 24, 2016
Restore 1.8.xsd and create new 1.10 one reflecting the changes made. Original Pull Request: #389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now accept String data types for boolean flags in XML configurations. Boolean data types in the XSD don't allows use of property placeholders even if the resolved value could be converted to boolean. Affected fields by this change are:
<mongo:repositories create-query-indexes=… /><mongo:options ssl=…/><mongo:client-options ssl=… />Related ticket: DATAMONGO-1490