Skip to content

DATAMONGO-1490 - Change the XML data type of boolean flags to String. #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Sep 13, 2016

We now accept String data types for boolean flags in XML configurations. Boolean data types in the XSD don't allows use of property placeholders even if the resolved value could be converted to boolean. Affected fields by this change are:

  • <mongo:repositories create-query-indexes=… />
  • <mongo:options ssl=…/>
  • <mongo:client-options ssl=… />

Related ticket: DATAMONGO-1490

@mp911de mp911de changed the title DATAMONGO-1490 - Change the XML data type of boolean flags boolean to String. DATAMONGO-1490 - Change the XML data type of boolean flags to String. Sep 13, 2016
@mp911de mp911de force-pushed the issue/DATAMONGO-1490 branch from ef9ed99 to f7a2458 Compare September 13, 2016 09:17
We now accept String data types for boolean flags in XML configurations. Boolean data types in the XSD don't allows use of property placeholders even if the resolved value could be converted to boolean. Affected fields by this change are:

* `<mongo:repositories create-query-indexes=… />`
* `<mongo:options ssl=…/>`
* `<mongo:client-options ssl=… />`
Restore 1.8.xsd and create new 1.10 one reflecting the changes made.
@@ -37,8 +37,8 @@ Defines a MongoClient instance used for accessing MongoDB.
<tool:annotation>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove changes to this file entirely from the PR.

christophstrobl pushed a commit that referenced this pull request Oct 24, 2016
We now accept String data types for boolean flags in XML configurations. Boolean data types in the XSD don't allows use of property placeholders even if the resolved value could be converted to boolean. Affected fields by this change are:

* `<mongo:repositories create-query-indexes=… />`
* `<mongo:options ssl=…/>`
* `<mongo:client-options ssl=… />`

Original Pull Request: #389
christophstrobl pushed a commit that referenced this pull request Oct 24, 2016
christophstrobl added a commit that referenced this pull request Oct 24, 2016
Restore 1.8.xsd and create new 1.10 one reflecting the changes made.

Original Pull Request: #389
@christophstrobl christophstrobl deleted the issue/DATAMONGO-1490 branch October 24, 2016 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants