Skip to content

Add support of $min and $max update operators #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add support of $min and $max update operators #353

wants to merge 2 commits into from

Conversation

odiszapc
Copy link
Contributor

For some reason $min and $max are not yet supported. Diff adds two methods into the org.springframework.data.mongodb.core.query.Update class. Diff speaks for itslef and works pretty well for me.

@odiszapc
Copy link
Contributor Author

It's a very simple commit. Please let me know does it conform you needs

@mp911de
Copy link
Member

mp911de commented Mar 30, 2016

Thanks @odiszapc for the PR. Would you mind adding some tests and creating a Jira ticket at https://jira.spring.io/browse/DATAMONGO?

Can you please sign, if you haven't done already, the CLA form for Spring Data Access with project lead Oliver Gierke and add your CLA Number as comment to this issue or the newly created Jira ticket?

@odiszapc
Copy link
Contributor Author

Sure, @mp911de

@odiszapc
Check for null for $max/$min
a6d9ffc 
Add tests for $max/$min functionality
@odiszapc
Copy link
Contributor Author

@mp911de Added few tests to Update class

@mp911de
Copy link
Member

mp911de commented Mar 30, 2016

Great, I'll take it from here on.

@odiszapc
Copy link
Contributor Author

@mp911de Offtop: what's CLA Number for? Where should I use it and how?

@mp911de
Copy link
Member

mp911de commented Mar 30, 2016

A Contributor License Agreement (CLA) defines the terms under which intellectual property has been contributed to a company/project. With the ICLA (individual contributor) number we keep track that you allowed us to include your contibution. We usually include it in your commit message. You can read more here about CLA.

mp911de pushed a commit that referenced this pull request Mar 30, 2016
@odiszapc @mp911de
DATAMONGO-1404 - Add support for $min and $max update operators.
e42c89d 
Original pull request: #353.
CLA: 169820160330091912 (Alexey Plotnik)
mp911de added a commit that referenced this pull request Mar 30, 2016
@mp911de
DATAMONGO-1404 - Polishing.
ca7b642 
Add author tags. Update license headers. Reformat code. Replace FQCN with import and simple class name. Remove final keyword in test methods.

Original pull request: #353.
@mp911de
Copy link
Member

mp911de commented Mar 30, 2016

I pushed your code on our issue/DATAMONGO-1404 branch as we're about to release Hopper GA in the next day. I need to check with the team whether this change will be included into Hopper GA or the next release after Hopper. Thanks for the great work.

@mp911de mp911de self-assigned this Mar 30, 2016
@odiszapc
Copy link
Contributor Author

Thank you, Mark!

mp911de pushed a commit that referenced this pull request Apr 8, 2016
@odiszapc @mp911de
DATAMONGO-1404 - Add support for $min and $max update operators.
9feac13 
Original pull request: #353.
CLA: 169820160330091912 (Alexey Plotnik)
mp911de added a commit that referenced this pull request Apr 8, 2016
@mp911de
DATAMONGO-1404 - Polishing.
83d40da 
Add author and since tags. Update license headers. Reformat code. Replace FQCN with import and simple class name. Remove final keyword in test methods. Update documentation.

Original pull request: #353.
@mp911de
Copy link
Member

mp911de commented Apr 8, 2016

That's merged with 83d40da

There's an older ticket DATAMONGO-941 which I oversaw, need to revisit this topic. Sorry for the noise.

@mp911de mp911de closed this Apr 8, 2016
@mp911de mp911de reopened this Apr 8, 2016
@mp911de mp911de mentioned this pull request Apr 8, 2016
Closed
mp911de pushed a commit that referenced this pull request Apr 8, 2016
@odiszapc @mp911de
DATAMONGO-1404 - Add support for $min and $max update operators.
d7bf127 
Original pull request: #353.
CLA: 169820160330091912 (Alexey Plotnik)
mp911de added a commit that referenced this pull request Apr 8, 2016
@mp911de
DATAMONGO-1404 - Polishing.
987669b 
Add author and since tags. Update license headers. Reformat code. Replace FQCN with import and simple class name. Remove final keyword in test methods. Add tests for numeric values. Update documentation.

Original pull request: #353.
mp911de added a commit that referenced this pull request Apr 8, 2016
@mp911de
DATAMONGO-1412 - Document mapping rules for Java types to MongoDB rep…
ba575f1 
…resentation.

Related pull request: #353
Related ticket: DATAMONGO-1412
@mp911de mp911de mentioned this pull request Apr 8, 2016
Closed
christophstrobl pushed a commit that referenced this pull request May 2, 2016
@odiszapc @christophstrobl
DATAMONGO-1404 - Add support for $min and $max update operators.
8983bd2 
Original pull request: #353.
CLA: 169820160330091912 (Alexey Plotnik)
christophstrobl pushed a commit that referenced this pull request May 2, 2016
@mp911de @christophstrobl
DATAMONGO-1404 - Polishing.
d610761 
Add author and since tags. Update license headers. Reformat code. Replace FQCN with import and simple class name. Remove final keyword in test methods. Add tests for numeric values. Update documentation.

Original pull request: #353.
christophstrobl pushed a commit that referenced this pull request May 2, 2016
@mp911de @christophstrobl
DATAMONGO-1412 - Document mapping rules for Java types to MongoDB rep…
b2b9f34 
…resentation.

Original Pull Request: #359
Related pull request: #353
Related ticket: DATAMONGO-1404
christophstrobl pushed a commit that referenced this pull request May 2, 2016
@mp911de @christophstrobl
DATAMONGO-1412 - Document mapping rules for Java types to MongoDB rep…
dc936a5 
…resentation.

Original Pull Request: #359
Related pull request: #353
Related ticket: DATAMONGO-1404
christophstrobl pushed a commit that referenced this pull request May 2, 2016
@mp911de @christophstrobl
DATAMONGO-1412 - Document mapping rules for Java types to MongoDB rep…
034c90f 
…resentation.

Original Pull Request: #359
Related pull request: #353
Related ticket: DATAMONGO-1404
@christophstrobl
Copy link
Member

merged into master via 8983bd2. thanks @odiszapc

christophstrobl pushed a commit that referenced this pull request May 3, 2016
@odiszapc @christophstrobl
DATAMONGO-1404 - Add support for $min and $max update operators.
e3256e1 
Original pull request: #353.
CLA: 169820160330091912 (Alexey Plotnik)
christophstrobl pushed a commit that referenced this pull request May 3, 2016
@mp911de @christophstrobl
DATAMONGO-1404 - Polishing.
c8df0d6 
Add author and since tags. Update license headers. Reformat code. Replace FQCN with import and simple class name. Remove final keyword in test methods. Add tests for numeric values. Update documentation.

Original pull request: #353.
christophstrobl pushed a commit that referenced this pull request May 3, 2016
@mp911de @christophstrobl
DATAMONGO-1404 - Polishing.
53ba6f5 
Add author and since tags. Update license headers. Reformat code. Replace FQCN with import and simple class name. Remove final keyword in test methods. Add tests for numeric values. Update documentation.

Original pull request: #353.
christophstrobl pushed a commit that referenced this pull request May 3, 2016
@mp911de @christophstrobl
DATAMONGO-1412 - Document mapping rules for Java types to MongoDB rep…
8c6048d 
…resentation.

Original Pull Request: #359
Related pull request: #353
Related ticket: DATAMONGO-1404
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odiszapc @mp911de @christophstrobl