DATAMONGO-1326 - Add support for $lookup to aggregation. #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophstrobl
pushed a commit
that referenced
this pull request
Mar 4, 2016
Original Pull Request: #344 CLA: 164120160221125037 (Alessio Fachechi)
christophstrobl
added a commit
that referenced
this pull request
Mar 4, 2016
Updated javadoc and formatting. Added tests and avoid unnecessary code blocks. Original Pull Request: #344
mp911de
added a commit
that referenced
this pull request
Mar 4, 2016
…erator. We now distinguish between aggregation operations that replace fields in the aggregation pipeline and those which inherit fields from previous operations. InheritsFieldsAggregationOperation is a nested interface of FieldsExposingAggregationOperation is a marker to lookup fields along the aggregation context chain. Added unit and integration tests. Mention lookup operator in docs. Original pull request: #344.
mp911de
added a commit
that referenced
this pull request
Mar 7, 2016
…erator. We now distinguish between aggregation operations that replace fields in the aggregation pipeline and those which inherit fields from previous operations. InheritsFieldsAggregationOperation is a nested interface of FieldsExposingAggregationOperation is a marker to lookup fields along the aggregation context chain. Added unit and integration tests. Mention lookup operator in docs. Original pull request: #344.
christophstrobl
pushed a commit
that referenced
this pull request
Mar 8, 2016
Original Pull Request: #344 CLA: 164120160221125037 (Alessio Fachechi)
christophstrobl
added a commit
that referenced
this pull request
Mar 8, 2016
…terface. Updated javadoc and formatting. Added tests and removed marker interface. Original Pull Request: #344
christophstrobl
pushed a commit
that referenced
this pull request
Mar 8, 2016
…erator. We now distinguish between aggregation operations that replace fields in the aggregation pipeline and those which inherit fields from previous operations. InheritsFieldsAggregationOperation is a nested interface of FieldsExposingAggregationOperation is a marker to lookup fields along the aggregation context chain. Added unit and integration tests. Mention lookup operator in docs. Original pull request: #344.
|
thanks @alessiofachechi . |
|
Thanks to you @christophstrobl and @mp911de, the code looks more pretty now! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now A/F MongoDB $lookup operation is supported.
For this purpose now
ExposedFieldsAggregationOperationContextforesees anadditionalmode, which allows for exposing new fields in addition to the ones exposed at the moment: unlike the group and project operations, the lookup operation in fact adds a new field to the previous field-set.