Query on nested id field incorrectly returns no results [DATAMONGO-2221]

[spring-projects-issues]

Joseph Blair opened DATAMONGO-2221 and commented

I previously reported this issue in DATAMONGO-2193.  Upgrading to 2.1.5 fixed the issue I reported in that ticket, however, it has reappeared in a different (but similar) use case.  The behavior is the same, where it appears that the driver is submitting my query value as an ObjectId instead of a regular string.  This is confirmed by the fact that changing the value in the database to an ObjectId causes it to be returned by the same query.

I'm at a loss as to why the two cases are behaving differently since they are annotated the same way.  My only guess is that this new case is doubly nested, rather than singly nested (eg, recipient.id versus trigger.assignee.id).

I commented this on the old ticket, but couldn't find a way to reopen it, so I submitted this one.  Let me know if it's easier to work off the old ticket instead, or if there's any additional information I can provide that would be useful.  Thanks

---

Affects: 2.1.5 (Lovelace SR5)

Referenced from: pull request #732

Backported to: 2.1.6 (Lovelace SR6)

[spring-projects-issues]

Christoph Strobl commented

Thank you Joseph Blair. I added at test for the QueryMapper to issue/DATAMONGO-2221 which seems to be fine. Can you share a breaking snippet?

[spring-projects-issues]

Joseph Blair commented

Sure.  The top-level class contains this field:

private NotificationTrigger trigger;

Some of the subclasses of that class have this field:

private TaskAssignee assignee;

Which has this field: 

@Field("id")
private String id; 

When running a query that includes a filter on that id field with a string value that resembles a Mongo ObjectId, the driver appears to be converting the string to an ObjectId, which causes documents to incorrectly not be matched.

Criteria.where("trigger.assignee.type").is("group").and("trigger.assignee.id").is(assignedGroup)

I confirmed this by changing the value for a document in the database from a string to an ObjectId, and then it was returned.  I also confirmed that reverting from version 2.1.5 to 2.0.5 fixes the problem, so there seems to be some kind of regression.  It's not clear to me why the change in 2.1.5 fixed DATAMONGO-2193 but not this, since they seem to be very similar; the double vs. triple-nesting is the only difference I can see

[spring-projects-issues]

Joseph Blair commented

Is there somewhere I can pull down and test the changes for this?  Based on the process from the last ticket, I tried pulling 2.2.0.DATAMONGO-2221-SNAPSHOT (per the linked PR) but that doesn't seem to exist

[spring-projects-issues]

Christoph Strobl commented

@Joseph Blair it's in the Spring snapshot repo.

<repository>
  <id>spring-libs-snapshot</id>
  <name>Spring Snapshot Repository</name>
  <url>https://repo.spring.io/libs-snapshot</url>
</repository>

[spring-projects-issues]

Joseph Blair commented

After adding that repository, and trying to change the project dependency to this:

<dependency>
	<groupId>org.springframework.data</groupId>
	<artifactId>spring-data-mongodb</artifactId>
	<version>2.2.0.DATAMONGO-2221-SNAPSHOT</version>
</dependency>

It is unable to compile, with this message:

[ERROR] error reading /Users/blairj/.m2/repository/org/mongodb/mongo-java-driver/3.10.1/mongo-java-driver-3.10.1.jar; invalid END header (bad central directory size)

From there, there are a bunch of code errors that mostly seem to be about not finding various Mongo-related classes