NullPointerException with null argument when using IgnoreCase [DATAMONGO-1608]

[spring-projects-issues]

Edward Prentice opened DATAMONGO-1608 and commented

findByName(null); // returns null
findByNameIgnoreCase(null) // throws NPE from MongoQueryCreator:302

Demonstration based off a spring-data example app

StackOverflow question asking how to handle this

Sorry I might have got the version wrong. I don't know what "GA" or "M1" mean! Sorry!

How can I help?

---

Affects: 1.10 GA (Ingalls), 1.9.7 (Hopper SR7)

Reference URL: EdwardPrentice/gs-accessing-data-mongodb@f2aec61

Issue Links:

• DATAMONGO-2424 IllegalArgumentException with null argument when using IgnoreCase

Referenced from: pull request #439

Backported to: 1.10.1 (Ingalls SR1), 1.9.8 (Hopper SR8)

[spring-projects-issues]

Oliver Drotbohm commented

There's an unguarded ….toString() on the way to applying the ignore case which we need to fix. Thanks for bringing this up. Should be an easy one.

[spring-projects-issues]

Edward Prentice commented

Awesome - is there a New Developer Guide or similar to help me get started?

[spring-projects-issues]

Edward Prentice commented

So, I've added what I think is a correctly failing test that verifies the defect, although I'm struggling to know what the fix should be. Could probably finish the fix with a little nudge in the right direction.

Any chance of getting a little help? Progress so far here. Thanks

[spring-projects-issues]

Oliver Drotbohm commented

Doesn't look too bad. Please file a PR, so that we can discuss the code over there

[spring-projects-issues]

Edward Prentice commented

Awesome - PR opened

[spring-projects-issues]

Oliver Drotbohm commented

Thanks, I've added a comment. Christoph Strobl — Would you mind taking it from there once the requested change is in place?

[spring-projects-issues]

Christoph Strobl commented

sure - on my todo list

[spring-projects-issues]

Edward Prentice commented

PR ready :)

[spring-projects-issues]

Christoph Strobl commented

Thanks EdwardPrentice! I'll take it from here