Type hint is missing when using BulkOperations.insert [DATAMONGO-1534]

[spring-projects-issues]

schoster barak opened DATAMONGO-1534 and commented

when inserting a list of documents

mongoTemplate.bulkOps(BulkOperations.BulkMode.UNORDERED, FOO.class, collectionName)
  .insert(foos);

the type info written in _class element is missing.

as a result, the class cannot be read back.
This make bulkOps insert method unusable

---

Affects: 1.9.4 (Hopper SR4)

Reference URL: https://github.com/spring-projects/spring-data-mongodb/blob/master/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/DefaultBulkOperations.java#L120

Referenced from: pull request #415, and commits c8709fe, 8e90366, 9059a77, e5a41ad, d272b26

Backported to: 1.10 RC1 (Ingalls), 1.9.6 (Hopper SR6)

2 votes, 2 watchers

[spring-projects-issues]

Christoph Strobl commented

thanks for reporting. seems mongoOperations.getConverter().write(document, dbo) would have been the way to go. Will take care.

[spring-projects-issues]

schoster barak commented

Thank you. do you think there is a workaround that can be used in one of the currently released versions?

i think that it could have been handled if DefaultBulkOperations could be extended (or an interface that could have been implemented in other way, or an abstract etc...) and the inherited custom class would be used at MongoTemplate at that line:
https://github.com/spring-projects/spring-data-mongodb/blob/master/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoTemplate.java#L576

[spring-projects-issues]

Christoph Strobl commented

You could also do the conversion out of BulkOperations.insert by just calling mongoOperations.getConverter().write(source, sink) and pass that one in.

@Test
public void insertShouldConsiderInheritance() {

	SpecialDoc specialDoc = new SpecialDoc();
	specialDoc.id = "id-1";
	specialDoc.value = "value";
	specialDoc.specialValue = "special-value";

	DBObject sink = new BasicDBObject();
	operations.getConverter().write(specialDoc, sink);

	createBulkOps(BulkMode.ORDERED).insert(Arrays.asList(sink)).execute();

	BaseDoc doc = operations.findOne(query(where("_id").is(specialDoc.id)), BaseDoc.class, COLLECTION_NAME);

	assertThat(doc, notNullValue());
	assertThat(doc, instanceOf(SpecialDoc.class));
}

[spring-projects-issues]

schoster barak commented

i can not do that since DefaultBulkOperations is not a public class

[spring-projects-issues]

Christoph Strobl commented

maybe I'm missing something but BulkOperations.insert can be called on the interface, so can operations.getConverter().
So what's wrong with:

DBObject sink = new BasicDBObject();
mongoOperations.getConverter().write(specialDoc, sink);

mongoOperations.bulkOps(ORDERED, collection).insert(asList(sink)).execute();

[spring-projects-issues]

schoster barak commented

it seems i am the one who's missing out :(

interface BulkOperations

has only one implementer:

DefaultBulkOperations

it's insert method contains the method "convertToMongoType"

	@Override
	public BulkOperations insert(Object document) {

		Assert.notNull(document, "Document must not be null!");

		bulk.insert((DBObject) mongoOperations.getConverter().convertToMongoType(document));
		return this;
	}

using

mongoOperations.bulkOps(ORDERED, collection).insert(asList(sink)).execute();

will eventually call:

bulk.insert((DBObject) mongoOperations.getConverter().convertToMongoType(document));

which removes the _class field

[spring-projects-issues]

Christoph Strobl commented

the trick would be to create the DBObject already by calling mongoOperations.getConverter().write(specialDoc, sink) before even passing it to the BulkOperations. now that it is already a DBObject the MongoConverter will not do any conversion any more. no need to subclass anything just do the conversion before adding the document to the bulk ops.