Parse error into GeoJsonPoint if coordinates are "integers" [DATAMONGO-1453]

[spring-projects-issues]

Javier Caselli opened DATAMONGO-1453 and commented

When mapping a document containing a GeoJSON location into a GeoJsonPoint object, if the location coordinates are "round" numbers (e.g. [0,0]) I get a ClassCastException:

Failed to convert from type \[com.mongodb.BasicDBObject\] to type \[org.springframework.data.mongodb.core.geo.GeoJsonPoint\] for value '\{ "type" : "Point" , "coordinates" : [ 0 , 0]\}'; nested exception is java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.Double

---

Affects: 1.8.4 (Gosling SR4)

Referenced from: pull request #369

Backported to: 1.9.3 (Hopper SR3), 1.8.5 (Gosling SR5)

[spring-projects-issues]

Christoph Strobl commented

good catch - seems to happen when data is inserted not using Spring Data and the GeoJson types in first place.

this one passes:

WithGeoJson wgj = new WithGeoJson();
wgj.id = "1";
wgj.description = "datamongo-1453";
wgj.point = new GeoJsonPoint(0, 0);

template.save(wgj);

assertThat(template.findOne(query(where("id").is(wgj.id)), WithGeoJson.class).point, is(equalTo(wgj.point)));

this one fails:

BasicDBObject point = new BasicDBObject();
point.put("type", "Point");
point.put("coordinates", new BasicDbListBuilder().add(0).add(0).get());

BasicDBObject outer = new BasicDBObject();
outer.append("_id", "datamongo-1453");
outer.append("description", "datamongo-1453");
outer.append("point", point);

this.factory.getDb().getCollection("withGeoJson").insert(outer);

assertThat(template.findOne(query(where("id").is("datamongo-1453")), WithGeoJson.class).point, is(equalTo(wgj.point)));

will fix that!

[spring-projects-issues]

Javier Caselli commented

In my case, I'm using a Repository Query (ignore the first one):

public interface TourActivityInfoRepository extends Repository<TourActivityInfoDoc, Long> {
	
	@Query(value = "{'categoryAnd.typeList.code' : {$in: ?0}}")
	public List<TourActivityInfoDoc> findByTypeIn(List<String> type);
	
	@Query(value = "{'location' : {'$geoWithin' : {'$box' : ?0}}}")
	public List<TourActivityInfoDoc> findByLocationWithin(Box box);
	
	@Query(value = "{'categoryAnd.typeList.code' : {$in: ?0}, 'location' : {'$geoWithin' : {'$box' : ?1}}}")
	public List<TourActivityInfoDoc> findByByTypeInAndLocationWithin(List<String> type, Box box);
}

The TourActivityInfoDoc class being something like:

@Document(collection="TourActivityInfo")
public class TourActivityInfoDoc implements Serializable {

	@Id
	private String id;
	
	private String description;
		
	private GeoJsonPoint location;

        // Getters, setters, etc.
        ...
}

[spring-projects-issues]

Christoph Strobl commented

@Javier Caselli I've just pushed some changes to issue/DATAMONGO-1453 would you mind giving the 1.10.0.DATAMONGO-1453-SNAPSHOT a try. It's already available via https://repo.spring.io

[spring-projects-issues]

Javier Caselli commented

@cstrobl Awesome, I'll give it a shot ASAP and get back to you guys! (y)

[spring-projects-issues]

Javier Caselli commented

@Christoph Strobl That did the magic, now it maps the coordinates even if they're integer numbers. Thanks!

[spring-projects-issues]

Christoph Strobl commented

thanks Javier Caselli for checking!

[spring-projects-issues]

Javier Caselli commented

My pleasure