Nested document update doesn't apply converters on embedded maps [DATAMONGO-1423]

[spring-projects-issues]

Andrew Onischenko opened DATAMONGO-1423 and commented

When trying to perform a direct update a nested document which is a map by

$set : {'metadata.thumbnails' : Map<Enum, String>}

the the map keys are not converted

Meanwhile, updating the core level object works properly

$set : {a: metadata}

For example:

Entity class

public class Video {
    ....
    private VideoMetadata metadata;
    ....
}

Nested object

public class VideoMetadata {
    ....
 	private Map<ThumbnailType, String> thumbnails;
    ....
}

Enum

public enum ThumbnailType {
	DEFAULT,  MEDIUM, HIGH, STANDARD, MAXRES
}

Invoked Dao method to update thumbnails

Query query = Query.query(Criteria.where("_id").is(id);
Update update = new Update()
	.set("metadata.thumbnails", metadata.getThumbnails());
	.set("metadata2", metadata);
}
mongoOps.updateFirst(query, update, Video.class);

Just after performing the update my objects looks like

{ 
    "_id" : ... ,
    "_class" :  ... ,
    ......
    "metadata" : {
        "thumbnails" : {
            "MEDIUM" : "a", 
            "DEFAULT" : "b", 
            "STANDARD" : "c"
        }, 
    "metadata2" : {
        "thumbnails" : {
            "medium" : "a", 
            "default" : "b", 
            "standard" : "c"
        }
    }
}

The only workaround I can find is to call converter manually :

DBObject dbObject = new BasicDBObject();
mongoOps.getConverter().write(metadata.getThumbnails(), dbObject);
dbObject.removeField("_class");
update.set("metadata.thumbnails", dbObject);

---

Affects: 1.8.4 (Gosling SR4), 1.9.1 (Hopper SR1)

Attachments:

• screenshot-1.png (21.69 kB)

Issue Links:

• DATAMONGO-1486 Changes to MappingMongoConverter Result in Class Cast Exception

Referenced from: pull request #365

Backported to: 1.9.2 (Hopper SR2), 1.8.5 (Gosling SR5)

[spring-projects-issues]

Christoph Strobl commented

Andrew Onischenko I've been trying to reproduce the issue you're facing without any luck. Maybe I am missing something here but the mapping seems to be fine for both

Update update = new Update().set("metadata.thumbnails", Collections.singletonMap(MEDIUM, "a"));

and

VideoMetadata metadata = new VideoMetadata(Collections.singletonMap(MEDIUM, "a"));
Update update = new Update().set("metadata", metadata);

Can you craft a failing testcase that reproduces the error?

[spring-projects-issues]

Andrew Onischenko commented

You may use this link GitHub repository with a failing testcase project to reproduce the issue.
Please update application.properties file and run the unit-test.

You will get something like this:
!screenshot-1.png!

Also you can see, that serialization|deserialization works properly within this app, but it really matters to me that all enum values are converted properly.

Thx for your support,
WBR Andrew Onischenko

[spring-projects-issues]

Andrew Onischenko commented

Pls use the comment above to reproduce the issue

[spring-projects-issues]

Christoph Strobl commented

thanks Andrew Onischenko good catch - seems like in this special case the key of the MapEntry is not correctly converted into its MongoDB representation.