Skip to content

Fix limit of FetchableFluentQueryBySpecification. #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Fix limit of FetchableFluentQueryBySpecification. #3601

merged 1 commit into from
Sep 2, 2024

Conversation

JingBh
Copy link
Contributor

@JingBh JingBh commented Aug 29, 2024

A very simple fix that closes #3600

This fix makes the two implementations of FluentQuery.FetchableFluentQuery behave the same (which they formerly don't), so I think it's not an API change.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 29, 2024
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 30, 2024
@mp911de mp911de merged commit d08b69d into spring-projects:main Sep 2, 2024
7 checks passed
mp911de pushed a commit that referenced this pull request Sep 2, 2024
mp911de pushed a commit that referenced this pull request Sep 2, 2024
@mp911de mp911de added this to the 3.2.10 (2023.1.10) milestone Sep 2, 2024
@mp911de mp911de self-assigned this Sep 2, 2024
@mp911de
Copy link
Member

mp911de commented Sep 2, 2024

Thank you for your contribution. That's merged and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limit in FetchableFluentQueryBySpecification addes duplicate order by clause
3 participants