Skip to content

Cleaned up EnversRevisionRepositoryImpl #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

arefbehboudi
Copy link
Contributor

Cleaned up EnversRevisionRepositoryImpl the code to enhance readability and maintainability

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 12, 2024
@schauder schauder added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 19, 2024
schauder pushed a commit that referenced this pull request Aug 19, 2024
schauder added a commit that referenced this pull request Aug 19, 2024
Original pull request #3576
@schauder
Copy link
Contributor

Thanks for submitting this PR.

We try to avoid the stream API since it is prone to introduce performance issues.
This is not a problem for 99.9% of the application, but it is a problem for libraries like Spring Data.

I merged the rest of your changes.

@schauder schauder closed this Aug 19, 2024
@schauder schauder added this to the 3.4 M1 (2024.1.0) milestone Aug 19, 2024
@arefbehboudi
Copy link
Contributor Author

arefbehboudi commented Aug 20, 2024

Thank you for your time @schauder .
Can you explain or recommend an article about Stream API performance issues?

@schauder
Copy link
Contributor

Can you explain or recommend an article about Stream API performance issues?

No, sorry. This is based on our own experience. Years back we replaced a lot of stuff with streams, just to change it back after we realised it had a performance impact.

Again: For most applications this is not an issue, except for when you are on some really hot code path. But with a library almost anything might end up being part of a hot code path for someone.

@arefbehboudi
Copy link
Contributor Author

Thank you so much @schauder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants