Render entire statement after applying sort. #3264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes sure to render the entire statement after applying the sort expression via the QueryEnhancer. Previously only parts, the actual statement body, had been considered.
quaff
reviewed
Dec 12, 2023
| @@ -179,6 +179,17 @@ void findsExistingOrderByIndependentOfCase() { | |||
| assertThat(query).endsWithIgnoringCase("ORDER BY p.firstname, p.lastname asc"); | |||
| } | |||
|
|
|||
| @Test // GH-3263 | |||
| void doesNotDropWithExpressionWhenApplySort() { | |||
There was a problem hiding this comment.
It's better to use Sorting instead of Sort for consistency.
There was a problem hiding this comment.
thanks @quaff - additionally I'm not happy with the doesNotDrop part. will rename the method.
|
Looks good, feel free to merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure to render the entire statement after applying the sort expression via the
QueryEnhancer.Previously only parts, the actual statement body, had been considered.
Fixes: #3263