Refactored AssertJ assertions into more readable ones #2746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
approved these changes
Jan 11, 2023
mp911de
reviewed
Jan 11, 2023
| @@ -96,22 +97,22 @@ void setup() { | |||
| @Test // DATAJPA-612 | |||
| void shouldRespectConfiguredJpaEntityGraph() { | |||
|
|
|||
| Assume.assumeTrue(currentEntityManagerIsAJpa21EntityManager(em)); | |||
| assumeThat(currentEntityManagerIsAJpa21EntityManager(em)).isTrue(); | |||
There was a problem hiding this comment.
Some lines like this one require reformatting because the tabs indents were replaced with space indents.
There was a problem hiding this comment.
sorry for that, fixed in newest update
krzyk
force-pushed
the
optimize-assertj-assertions2
branch
from
dfc3a27 to
8b5ad62
Compare
krzyk
force-pushed
the
optimize-assertj-assertions2
branch
from
8b5ad62 to
f6e1f10
Compare
|
Thanks @krzyk! I just applied a touch of polishing and merged it to |
gregturn
added
type: enhancement
gregturn
added a commit
that referenced
this pull request
Jan 24, 2023
mp911de
added
type: task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized AssertJ assertions into more readable ones (and giving better error messages) also replaced junit assumptions with AssertJ ones (for consistency).