`NullPointerException` in version 3.0.2 when using modifying native queries or `SELECT` queries that Spring Data cannot parse

[The-Arne]

Commit 64b5a22 introduced a null pointer exception in line 620 of QueryUtils. If a native query is not a select, but, for example, a delete, "variable" will be null, leading to said exception.

Example code in repository:

	@Modifying
	@Query(value = "delete from some_table where id in :ids", nativeQuery = true)
	void deleteStuffFromSomeTable(@Param("ids") Collection<UUID> ids);

Relevant part of the trace:

Caused by: java.lang.NullPointerException: Cannot invoke "String.contains(java.lang.CharSequence)" because "variable" is null
	at org.springframework.data.jpa.repository.query.QueryUtils.createCountQueryFor(QueryUtils.java:620)
	at org.springframework.data.jpa.repository.query.DefaultQueryEnhancer.createCountQueryFor(DefaultQueryEnhancer.java:49)
	at org.springframework.data.jpa.repository.query.StringQuery.deriveCountQuery(StringQuery.java:111)
	at org.springframework.data.jpa.repository.query.AbstractStringBasedJpaQuery.<init>(AbstractStringBasedJpaQuery.java:82)
	at org.springframework.data.jpa.repository.query.NativeJpaQuery.<init>(NativeJpaQuery.java:58)
	at org.springframework.data.jpa.repository.query.JpaQueryFactory.fromMethodWithQueryString(JpaQueryFactory.java:53)
	at org.springframework.data.jpa.repository.query.JpaQueryLookupStrategy$DeclaredQueryLookupStrategy.resolveQuery(JpaQueryLookupStrategy.java:170)
	at org.springframework.data.jpa.repository.query.JpaQueryLookupStrategy$CreateIfNotFoundQueryLookupStrategy.resolveQuery(JpaQueryLookupStrategy.java:252)
	at org.springframework.data.jpa.repository.query.JpaQueryLookupStrategy$AbstractQueryLookupStrategy.resolveQuery(JpaQueryLookupStrategy.java:95)
	at org.springframework.data.repository.core.support.QueryExecutorMethodInterceptor.lookupQuery(QueryExecutorMethodInterceptor.java:111)
	... 79 more

[unkish]

Also affects 2.7.8

A simple test for QueryEnhancerTckTests that would reproduce issue:

    @Test
    void nativeUpdateQueryThrowsException() {
        DeclaredQuery declaredQuery = DeclaredQuery.of("delete from some_table where id in :ids", true);
        QueryEnhancer enhancer = createQueryEnhancer(declaredQuery);
        assertThatNoException().isThrownBy(() -> enhancer.createCountQueryFor(null));
    }

"Offending" query itself can be also:

• UPDATE table_name SET column_name = a_value"
• BEGIN ... WHEN MATCHED THEN ... END;
• ...

[ayrtonnadgel]

In my case, the NPE occurs querying a sequence value.

@Query(value = "SELECT nexval('public.my_sequence')", nativeQuery = true)
Integer getNextvalMySequence();

[gideruette]

Same here, with non CRUD native query (spring-jpa 2.7.8)

@Query(value = """
select count(1) as totalItems,
sum(case when myField is null then 0 else 1 end) as notNullItems
from myClass
""", nativeQuery = true)

Found a workaround by adding a fictive countQuery

@Query(value = """
select count(1) as totalItems,
sum(case when myField is null then 0 else 1 end) as notNullItems
from myClass
""", countQuery = "select 1", nativeQuery = true)

Same with an UPDATE query in 2.7.9:

  @Modifying
  @Query(nativeQuery = true, value = "UPDATE seq_mgmt SET seq_no = :value WHERE seq_id = :key")
  int setNextValue(@Param("key") String key, @Param("value") Long value);