Skip to content

Fix: missing PhraseSuggestion.Entry.Option's score and collateMatch values #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2023

Conversation

sebastien-comeau
Copy link
Contributor

@sebastien-comeau sebastien-comeau commented Aug 29, 2023

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker. Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #2681

@pivotal-cla
Copy link

@sebastien-comeau Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 29, 2023
@pivotal-cla
Copy link

@sebastien-comeau Thank you for signing the Contributor License Agreement!

@sothawo
Copy link
Collaborator

sothawo commented Aug 29, 2023

Please check the points from the PR template

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker. Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@sebastien-comeau
Copy link
Contributor Author

sebastien-comeau commented Aug 30, 2023

@sothawo check points checked! 😄

@sothawo sothawo merged commit 7c46639 into spring-projects:main Sep 3, 2023
sothawo pushed a commit that referenced this pull request Sep 3, 2023
…alues.

Original Pull Request #2680
Closes #2681

(cherry picked from commit 7c46639)
sothawo pushed a commit that referenced this pull request Sep 3, 2023
…alues.

Original Pull Request #2680
Closes #2681

(cherry picked from commit 7c46639)
(cherry picked from commit 922f4b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phrase suggest options score value alway null.
5 participants