Skip to content

Fix inner hits metadata mapping. #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

JKatzwinkel
Copy link
Contributor

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker. Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #2521

In case of multiple inner hits within e.g. a nested query, all inner hits get assigned the same _nested metadata (i.e. offset etc.). This change fixes that, so that inner hits have the nested metadata that Elasticsearch actually returns.

@pivotal-cla
Copy link

@JKatzwinkel Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@JKatzwinkel Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 8, 2023
@sothawo sothawo merged commit 1f7fa77 into spring-projects:main Apr 10, 2023
sothawo pushed a commit that referenced this pull request Apr 10, 2023
Original Pull Request #2522
Closes #2521

(cherry picked from commit 1f7fa77)
sothawo pushed a commit that referenced this pull request Apr 10, 2023
Original Pull Request #2522
Closes #2521

(cherry picked from commit 1f7fa77)
(cherry picked from commit e1da43c)
@JKatzwinkel JKatzwinkel deleted the fix-2521_inner_hits branch April 10, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve Offsets of inner_hits
4 participants