-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Provide support for GetFieldMapping request #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for GetFieldMapping request #1641
Conversation
@ffaoudi Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@ffaoudi Thank you for signing the Contributor License Agreement! |
db99e9d
to
ad52127
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR, nice work. There's nothing to object, just some minor things
src/main/java/org/springframework/data/elasticsearch/client/util/RequestConverters.java
Outdated
Show resolved
Hide resolved
...ramework/data/elasticsearch/client/reactive/ReactiveElasticsearchClientIntegrationTests.java
Outdated
Show resolved
Hide resolved
...ramework/data/elasticsearch/client/reactive/ReactiveElasticsearchClientIntegrationTests.java
Outdated
Show resolved
Hide resolved
...g/springframework/data/elasticsearch/client/reactive/DefaultReactiveElasticsearchClient.java
Outdated
Show resolved
Hide resolved
...ramework/data/elasticsearch/client/reactive/ReactiveElasticsearchClientIntegrationTests.java
Outdated
Show resolved
Hide resolved
Hi @sothawo Thanks for the review, I have a question about the version, in the javadoc I put since 4.2, is that correct? |
31a42ce
to
25973a3
Compare
yes, 4.2 is correct. |
Closes #1641