Skip to content

Provide support for GetFieldMapping request #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

ffaoudi
Copy link
Contributor

@ffaoudi ffaoudi commented Jan 12, 2021

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #1641

@pivotal-issuemaster
Copy link

@ffaoudi Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 12, 2021
@pivotal-issuemaster
Copy link

@ffaoudi Thank you for signing the Contributor License Agreement!

@ffaoudi ffaoudi force-pushed the add-GetFieldMappingRequest branch from db99e9d to ad52127 Compare January 12, 2021 13:41
@sothawo sothawo linked an issue Jan 12, 2021 that may be closed by this pull request
@sothawo sothawo removed the status: waiting-for-triage An issue we've not yet triaged label Jan 12, 2021
@sothawo sothawo self-assigned this Jan 12, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 12, 2021
@sothawo sothawo removed the status: waiting-for-triage An issue we've not yet triaged label Jan 12, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 12, 2021
Copy link
Collaborator

@sothawo sothawo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, nice work. There's nothing to object, just some minor things

@ffaoudi
Copy link
Contributor Author

ffaoudi commented Jan 12, 2021

Hi @sothawo Thanks for the review, I have a question about the version, in the javadoc I put since 4.2, is that correct?

@ffaoudi ffaoudi force-pushed the add-GetFieldMappingRequest branch from 31a42ce to 25973a3 Compare January 12, 2021 21:56
@sothawo sothawo merged commit 3c6dd64 into spring-projects:master Jan 13, 2021
@sothawo
Copy link
Collaborator

sothawo commented Jan 13, 2021

yes, 4.2 is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for GetFieldMapping request in ReactiveElasticsearchClient
5 participants