NPE in ElasticsearchExceptionTranslator

[ztomic]

Hi,

I'm migrating from Spring Boot 2.7 to Spring Boot 3 and switching to new Spring Data Elasticsearch.

I have many problems with it (most of them with rewriting queries and aggregations from old to new Spring Data - since QueryBuilders class from here is missing queries, I must mix it with QueryBuilders from ES client and direct builders for query/aggregations from ES client - it is not the happiest solution that the QueryBuilders class in Spring Data Elasticsearch is named the same as in the ES client, and at many places I need to use ._toQuery() from QueryVariant)

Back to the topic, ElasticsearchExceptionTranslator is generating NullPointerException because ErrorResponse.error().type() is null:

Caused by: java.lang.NullPointerException: Cannot invoke "String.contains(java.lang.CharSequence)" because the return value of "co.elastic.clients.elasticsearch._types.ErrorCause.type()" is null
	at org.springframework.data.elasticsearch.client.elc.ElasticsearchExceptionTranslator.translateExceptionIfPossible(ElasticsearchExceptionTranslator.java:91)
	at org.springframework.data.elasticsearch.client.elc.ElasticsearchExceptionTranslator.translateException(ElasticsearchExceptionTranslator.java:62)
	at org.springframework.data.elasticsearch.client.elc.ChildTemplate.execute(ChildTemplate.java:73)

[sothawo]

Thanks for reporting that NPE, fixed in main and I wll as well backport it to 5.0.x.

As for the name clashing of QueryBuilders: I'll add a ticket to have this renamed in 5.1.

[ztomic]

Thanks!

[ztomic]

@sothawo when using Critera, how can we use Aggregation with it? Currently only possible solution as I can see is to copy CriteriaQueryProcessor (since it is package private) and use it's createQuery method and then use NativeQueryBuilder.

[sothawo]

Currently it is not possible. The problem with building the Elasticsearch Query and copying this is that this needs the Entity of the query for fieldname mapping or property converters which normally not used at the Spring Data Elasticsearch query creation level.

But it might be possible to add a Spring Data Elasticsearch instead of an Elasticsearch query into a NativeQuery and use that when the NativeQuery is processed. This would make only sense for StringQuery or CriteriaQeury and not for NativeQuery objects to be put in there. I created #2391 for this.

[ztomic]

That will be great, thanks!