ElasticsearchTemplate does not provide the scroll ID with startScroll [DATAES-459]

[spring-projects-issues]

Vincent Bories-Azeau opened DATAES-459 and commented

The scan and scroll operations declared in the ElasticsearchOperations interface and its implementation in ElasticsearchTemplate are unusable because the API returns a Page instance, instead of a ScrolledPage instance, at least. We can never get the scroll ID to perform further scroll operations.

The SearchResultMapper used under the hood returns an AggregatedPage, but it is completely hidden in the ElasticsearchTemplate class, where all startScroll methods return a Page instance.

The issue DATAES-445 already pointed out documentation issues, without explicitly talking about the API unusability.

Thanks in advance for your help.

 

---

Affects: 3.0.7 (Kay SR7)

Referenced from: pull request #274

2 votes, 3 watchers

[spring-projects-issues]

Sylvain LAURENT commented

Why dont *Scroll return an AggregatedPage?

Currently we have to cast which is ugly. Even the unit tests perform a blind cast.

And yes, the doc is totally out of date