DATACOUCH-36 - Don't allow NULL values to be stored. #9
Conversation
It is illegal to store a NULL value as a document. An attempt to do so will throw an IllegalArgumentException. -=david=-
DATACOUCH-36 - Don't allow NULL values to be stored.
|
👍 thanks! |
|
You're welcome :) |
| private void verifyValueType(final Object value) { | ||
| if(value == null) { | ||
| throw new IllegalArgumentException("Attribute of type null cannot be stored."); | ||
| } |
There was a problem hiding this comment.
Considering that:
{
"field1": {
"field11": 123
},
"field2": null,
"field3": "abc"
}
is valid json. Why the code throws exception in case of null value?
There was a problem hiding this comment.
right, I think that came from the fact that you cant store a NULL as a document in couchbase.. We should check somewhere else for that and allow it here probably.
There was a problem hiding this comment.
Would you like another Jira ticket for this or can I create another pull request for the same ticket? Possibly reopen the ticket to document the new changes?
There was a problem hiding this comment.
Hi @kdombeck jeah I think - since this one has already been released - we should do a new ticket and a new PR if you don't mind. cheers!
There was a problem hiding this comment.
There was a problem hiding this comment.
@kdombeck Any idea why I can't persist null fields (not null documents) using a CrudRepository? I want to save null fields.
Gem installation instructions updated
It is illegal to store a NULL value as a document. An attempt to do so will
throw an IllegalArgumentException.
-=david=-