Skip to content

DATACOUCH-526 - N1qlJoinResolver not escaping bucketNames with specia… #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikereiche
Copy link
Collaborator

…l characters

It escape the first bucket name, but not the second one.

I did not write a test case as the change seems trivial, and I don't know how to trigger the code-path affected.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [-] You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

…l characters

It escape the first bucket name, but not the second one.
@mikereiche mikereiche requested a review from daschl December 10, 2020 02:45
@mikereiche mikereiche merged commit 0494247 into master Dec 10, 2020
@mikereiche mikereiche deleted the datacouch_526_n1ql_join_resolve_handle_special_chars branch December 10, 2020 21:18
mikereiche added a commit that referenced this pull request Feb 16, 2021
…l characters (#291)

It escape the first bucket name, but not the second one.

Co-authored-by: mikereiche <michael.reiche@couchbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants