Skip to content

Move duplicate code in QueryCriteria to new method. #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

shubham101096
Copy link
Contributor

@shubham101096 shubham101096 commented Apr 1, 2023

Issue #1707. I extracted duplicated code fragment into a new method "private void checkAndAddToCriteriaChain()". The previous test cases are working and there is no need to add new cased as I did only refactoring.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 1, 2023
@shubham101096
Copy link
Contributor Author

I am a student. I was assigned the task of applying some specific refactoring techniques on any open source project in my assignment. I chose this project. I have applied extract method refactoring technique in QueryCriteria.java file. Please suggest any changes if required for getting this pull request approved. Thank you.

@mikereiche mikereiche merged commit 9c25814 into spring-projects:main Apr 5, 2023
mikereiche pushed a commit that referenced this pull request Jun 14, 2023
Co-authored-by: Shubham Mishra <sh277446@dal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants