-
Notifications
You must be signed in to change notification settings - Fork 192
Add suport for JsonValue annotation on Enums. #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikereiche
commented
Dec 1, 2022
src/main/java/org/springframework/data/couchbase/core/convert/AbstractCouchbaseConverter.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/couchbase/core/convert/CouchbaseCustomConversions.java
Show resolved
Hide resolved
.../org/springframework/data/couchbase/core/convert/CouchbasePropertyValueConverterFactory.java
Show resolved
Hide resolved
.../org/springframework/data/couchbase/core/convert/CouchbasePropertyValueConverterFactory.java
Show resolved
Hide resolved
.../org/springframework/data/couchbase/core/convert/CouchbasePropertyValueConverterFactory.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/data/couchbase/core/convert/translation/JsonValueConverter.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/data/couchbase/core/convert/translation/JsonValueConverter.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/data/couchbase/core/convert/translation/JsonValueConverter.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/data/couchbase/core/convert/translation/JsonValueConverter.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/data/couchbase/core/convert/translation/JsonValueConverter.java
Outdated
Show resolved
Hide resolved
249a39d
to
888ed12
Compare
mikereiche
commented
Dec 7, 2022
src/main/java/org/springframework/data/couchbase/core/convert/MappingCouchbaseConverter.java
Show resolved
Hide resolved
src/test/java/org/springframework/data/couchbase/domain/AirportJsonValuedObject.java
Show resolved
Hide resolved
888ed12
to
a424459
Compare
dnault
reviewed
Dec 7, 2022
.../org/springframework/data/couchbase/core/convert/CouchbasePropertyValueConverterFactory.java
Outdated
Show resolved
Hide resolved
.../org/springframework/data/couchbase/core/convert/CouchbasePropertyValueConverterFactory.java
Outdated
Show resolved
Hide resolved
.../org/springframework/data/couchbase/core/convert/CouchbasePropertyValueConverterFactory.java
Outdated
Show resolved
Hide resolved
.../org/springframework/data/couchbase/core/convert/CouchbasePropertyValueConverterFactory.java
Show resolved
Hide resolved
.../org/springframework/data/couchbase/core/convert/CouchbasePropertyValueConverterFactory.java
Outdated
Show resolved
Hide resolved
.../org/springframework/data/couchbase/core/convert/CouchbasePropertyValueConverterFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/couchbase/core/convert/JsonValueConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/couchbase/core/convert/JsonValueConverter.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/data/couchbase/domain/Airport.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/data/couchbase/domain/AirportJsonValuedObject.java
Show resolved
Hide resolved
1b05530
to
47a54c6
Compare
dnault
suggested changes
Dec 14, 2022
...main/java/org/springframework/data/couchbase/core/convert/IntegerToEnumConverterFactory.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/couchbase/core/convert/OtherConverters.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/couchbase/core/convert/OtherConverters.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/couchbase/core/convert/StringToEnumConverterFactory.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/data/couchbase/domain/Airport.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/couchbase/config/AbstractCouchbaseConfiguration.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/data/couchbase/domain/AirportJsonValuedObject.java
Show resolved
Hide resolved
84b3a40
to
54575e2
Compare
…r otherwise. Closes #1617.
54575e2
to
91f8358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the @ JsonValue annotation with a property-value converter.
Closes #1617.