Skip to content

Handle arguments that are lists. #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@ public CouchbaseList writeCollectionInternal(final Collection<?> source, final C
type, prop, accessor));
} else {
CouchbaseDocument embeddedDoc = new CouchbaseDocument();
writeInternalRoot(element, embeddedDoc, prop.getTypeInformation(), false, prop);
writeInternalRoot(element, embeddedDoc, prop != null ? prop.getTypeInformation() : TypeInformation.of(elementType), false, prop);
target.put(embeddedDoc);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,9 @@ private JsonObject getNamedPlaceholderValues(ParameterAccessor accessor) {
if (value instanceof CouchbaseDocument) {
value = ((CouchbaseDocument) value).export();
}
if (value instanceof CouchbaseList) {
value = ((CouchbaseList) value).export();
}
if (placeholder != null && placeholder.charAt(0) == ':') {
placeholder = placeholder.replaceFirst(":", "");
putNamedValue(namedValues, placeholder, value);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,11 @@ public interface UserSubmissionRepository extends CouchbaseRepository<UserSubmis
@ScanConsistency(query = QueryScanConsistency.REQUEST_PLUS)
List<Airport> setByIdAddress(String id, Address abc);

@Query("UPDATE #{#n1ql.bucket} set courses=$2 where meta().id=$1")
@ScanConsistency(query = QueryScanConsistency.REQUEST_PLUS)
void setOrderedCourses(String id, Course[] courses);

@Query("UPDATE #{#n1ql.bucket} set courses=$courses where meta().id=$id")
@ScanConsistency(query = QueryScanConsistency.REQUEST_PLUS)
void setNamedCourses(String id, Course[] courses);
}
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
import org.springframework.data.couchbase.domain.AirportMini;
import org.springframework.data.couchbase.domain.AirportRepository;
import org.springframework.data.couchbase.domain.AirportRepositoryScanConsistencyTest;
import org.springframework.data.couchbase.domain.Course;
import org.springframework.data.couchbase.domain.Iata;
import org.springframework.data.couchbase.domain.NaiveAuditorAware;
import org.springframework.data.couchbase.domain.Person;
Expand Down Expand Up @@ -855,7 +856,45 @@ void updateObject() throws Exception {
Optional<UserSubmission> fetched = userSubmissionRepository.findById(userSubmission.getId());
assertEquals(address, fetched.get().getAddress());
} finally {
airportRepository.deleteById(userSubmission.getId());
userSubmissionRepository.deleteById(userSubmission.getId());
}
}

@Test
void namedParameterList() throws Exception {
UserSubmission userSubmission = new UserSubmission();
userSubmission.setId("123");
try {
userSubmission.setUsername("updateObject");
userSubmissionRepository.save(userSubmission);
Course[] courses = new Course[]{ new Course("1", "2", "3"), new Course("4","5","6")};
userSubmissionRepository.setNamedCourses(userSubmission.getId(), courses);
Optional<UserSubmission> fetched = userSubmissionRepository.findById(userSubmission.getId());
assertEquals(courses.length, fetched.get().getCourses().size());
for(int i=0; i< courses.length; i++){
assertEquals(courses[i], fetched.get().getCourses().get(i));
}
} finally {
userSubmissionRepository.deleteById(userSubmission.getId());
}
}

@Test
void orderedParameterList() throws Exception {
UserSubmission userSubmission = new UserSubmission();
userSubmission.setId("123");
try {
userSubmission.setUsername("updateObject");
userSubmissionRepository.save(userSubmission);
Course[] courses = new Course[]{ new Course("1", "2", "3"), new Course("4","5","6")};
userSubmissionRepository.setOrderedCourses(userSubmission.getId(), courses);
Optional<UserSubmission> fetched = userSubmissionRepository.findById(userSubmission.getId());
assertEquals(courses.length, fetched.get().getCourses().size());
for(int i=0; i< courses.length; i++){
assertEquals(courses[i], fetched.get().getCourses().get(i));
}
} finally {
userSubmissionRepository.deleteById(userSubmission.getId());
}
}

Expand Down