Skip to content

Fix SimpleCouchbaseRepository not taking into account the default consistency. #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 19, 2021

Conversation

JesusTheHun
Copy link

@JesusTheHun JesusTheHun commented Oct 18, 2021

Setting default consistency should make all queries performed with said consistency.

This PR fixes the issue and add a non-regression test.

Closes #1243 .

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla This is an Obvious Fix

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 18, 2021
@JesusTheHun JesusTheHun changed the title Test default consistency being used with CouchbaseRepository findAll Fix SimpleCouchbaseRepository not taking into account the default consistency. Oct 18, 2021
@mikereiche mikereiche merged commit 9604193 into spring-projects:4.2.x Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants