Skip to content

Log exceptions thrown from events. #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2021
Merged

Log exceptions thrown from events. #1187

merged 1 commit into from
Aug 16, 2021

Conversation

mikereiche
Copy link
Collaborator

Closes #1075.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@mikereiche mikereiche requested a review from daschl August 13, 2021 23:34
daschl
daschl suggested changes Aug 14, 2021
View reviewed changes
src/main/java/org/springframework/data/couchbase/core/CouchbaseTemplateSupport.java Outdated
@@ -182,7 +182,7 @@ public void maybeEmitEvent(CouchbaseMappingEvent<?> event) {
try {
this.applicationContext.publishEvent(event);
} catch (Exception e) {
e.printStackTrace();
LOG.error("exception emitting event", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add the event to the log message so in logging you can figure out which event caused the error

src/main/java/org/springframework/data/couchbase/core/ReactiveCouchbaseTemplateSupport.java Outdated
@@ -189,7 +189,7 @@ public void maybeEmitEvent(CouchbaseMappingEvent<?> event) {
try {
this.applicationContext.publishEvent(event);
} catch (Exception e) {
e.printStackTrace();
LOG.error("exception emitting event", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add the event to the log message so in logging you can figure out which event caused the error

@mikereiche mikereiche force-pushed the datacouch_1075_log_event_exceptions branch from 6f73914 to a556c59 Compare August 16, 2021 20:14
@mikereiche mikereiche merged commit f8b5ab2 into main Aug 16, 2021
@mikereiche mikereiche deleted the datacouch_1075_log_event_exceptions branch September 14, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschl daschl daschl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CouchbaseTemplateSupport does not log exceptions thrown by CouchbaseMappingEvent Listeners correctly
2 participants
@mikereiche @daschl