DefaultCouchbaseTypeMapper uses TypeAlias annotation if present. #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultCouchbaseTypeMapper uses TypeAlias annotation if present. Test case also uncovered that TypeAlias was being ignored for string queries. Closes #1119.
mikereiche
commented
Apr 5, 2021
There was a problem hiding this comment.
This allows @typealias to be used out-of-the-box without creating CustomMappingCouchbaseConverter, TypeBasedCouchbaseTypeMapper, and TypeAwareInformationMapper classes.
| @@ -200,6 +217,7 @@ void count() { | |||
| airportRepository.saveAll( | |||
| Arrays.stream(iatas).map((iata) -> new Airport("airports::" + iata, iata, iata.toLowerCase(Locale.ROOT))) | |||
| .collect(Collectors.toSet())); | |||
| couchbaseTemplate.findByQuery(Airport.class).withConsistency(QueryScanConsistency.REQUEST_PLUS).all(); | |||
There was a problem hiding this comment.
This should have already been present.
| this.queryParser = new StringBasedN1qlQueryParser(queryString, queryMethod, bucketName, couchbaseConverter, | ||
| getTypeField(), getTypeValue(), accessor, spelExpressionParser, evaluationContextProvider); | ||
| getTypeField(), typeValue, accessor, spelExpressionParser, evaluationContextProvider); |
There was a problem hiding this comment.
This had just been using the classname. It needs to use TypeAlias annotation if present.
mikereiche
deleted the
datacouch_1119_default_mapper_recognizes_type_alias_annotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultCouchbaseTypeMapper uses TypeAlias annotation if present.
Test case also uncovered that TypeAlias was being ignored for
string queries.
Closes #1119.