Skip to content

DATACOUCH-34 - Can't deserialize long/Long/Date fields. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2013
Merged

DATACOUCH-34 - Can't deserialize long/Long/Date fields. #10

merged 1 commit into from
Oct 10, 2013

Conversation

dharrigan
Copy link
Contributor

Catch the attempt to parse a long as an int, then attempt to return a long value.

I'm not tooooo sure of the approach here, it's bizarre. There appears to be no VALUE_NUMBER_LONG in the JsonToken class and I find that confusing! At the moment, I'm just catching the attempt to parse an int where it throws an exception and then attempt to parse as a long. Seems to work grand.

-=david=-

Catch the attempt to parse a long as an int, then attempt to return a long value.

-=david=-
daschl added a commit that referenced this pull request Oct 10, 2013
DATACOUCH-34 - Can't deserialize long/Long/Date fields.
@daschl daschl merged commit 5ae7c76 into spring-projects:master Oct 10, 2013
@daschl
Copy link
Contributor

daschl commented Oct 10, 2013

thanks :)

@dharrigan
Copy link
Contributor Author

Hi Michael,

Sorry, hold off on the merge. I just realised that I made a mistake. It's
targeted to JDK1.8!!! Fixing it now.

-=david=-

On 10 October 2013 08:26, Michael Nitschinger notifications@github.comwrote:

thanks :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/10#issuecomment-26033866
.

I prefer encrypted and signed messages. KeyID: B20A22F9
Fingerprint: 110A F423 3647 54E2 880F ADAD 1C52 85BF B20A 22F9

"It is not usually until you've built and used a version of the program
that you understand the issues well enough to get the design right." - Rob
Pike, Brian Kernighan.

No trees were harmed in the sending of this message, however, a number of
electrons were inconvenienced.

@daschl
Copy link
Contributor

daschl commented Oct 10, 2013

oh, that wasn't obvious to me. Just submit another PR with the same DATACOUCH-34 prefix!

@dharrigan
Copy link
Contributor Author

Done.

I was mistaken, just my project level was set at 1.8. I've taken the
opportunity to improve the test with the new pull request (11).

-=david=-

On 10 October 2013 08:28, Michael Nitschinger notifications@github.comwrote:

oh, that wasn't obvious to me. Just submit another PR with the same
DATACOUCH-34 prefix!


Reply to this email directly or view it on GitHubhttps://github.com//pull/10#issuecomment-26033959
.

I prefer encrypted and signed messages. KeyID: B20A22F9
Fingerprint: 110A F423 3647 54E2 880F ADAD 1C52 85BF B20A 22F9

"It is not usually until you've built and used a version of the program
that you understand the issues well enough to get the design right." - Rob
Pike, Brian Kernighan.

No trees were harmed in the sending of this message, however, a number of
electrons were inconvenienced.

bclozel added a commit that referenced this pull request Oct 30, 2014
Fix directory name for sample pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants