DATACMNS-578 - PoC: Speed up instance creation by generating Factory classes with ASM. #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 13, 2014 16:34
…es with ASM. Prepare issue branch.
…es with ASM. Introduced BytecodeGeneratingEntityInstantiator which dynamically generates classes to speed up the dynamic instantiation of objects. Since we cannot support every use case with byte code generation we gracefully fallback to the ReflectiveEntityInstantiator. Original pull request: #98.
thomasdarimont
force-pushed
the
issue/DATACMNS-578
branch
from
af4c00a to
c76b15c
Compare
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private <T> Constructor<T> findAppropriateConstructorForArguments(Class<T> clazz, Object[] args) { |
There was a problem hiding this comment.
Is that really needed? If no PreferredConstructor is found we either deal with the case that there are only constructors available that take arguments but none of them has been annotated with @PersistenceConstructor. This is usually the case if a special converter is registered for that type so that we're never going to instantiate it anyway.
The other aspect is that the non-availability of a preferred constructor results in the argument array being empty so that we can only fallback to instantiating the implicit default constructor anyway. This is very likely to fail (except array instantiations) as the default constructor would've been detected during preferred constructor detection in the first place.
added 4 commits
October 17, 2014 15:24
…es with ASM. Cleaned up byte code generation and removed usage of JDK 8 specific types.
…es with ASM. Added support for unboxing of constructor parameters and more robust handling for cases where we cannot generate a custom ObjectInstantiator. In such cases we'll fall back to the ReflectiveEntityInstantiator.
…es with ASM. Removed book-keeping and logging for types which we cannot generate byte code for.
…es with ASM. Refactoring according to code review.
thomasdarimont
force-pushed
the
issue/DATACMNS-578
branch
from
22b0778 to
0ed1dff
Compare
thomasdarimont
pushed a commit
that referenced
this pull request
Oct 21, 2014
…es with ASM. Introduced BytecodeGeneratingEntityInstantiator which dynamically generates classes to speed up the dynamic instantiation of objects. Since we cannot support every use case with byte code generation we gracefully fallback to the ReflectiveEntityInstantiator. BytecodeGeneratingEntityInstantiator has support for unboxing of constructor parameters and more robust handling for cases where we cannot generate a custom ObjectInstantiator. Original pull request: #98.
odrotbohm
added a commit
that referenced
this pull request
Oct 21, 2014
Added some JavaDoc where missing. Better variable names and slightly parameter ordering changes. Formatting in the unit tests and reference to the original ticket. Original pull request: #98.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROOF-OF-CONCEPT please do not merge yet!
Introduced BytecodeGeneratingEntityInstantiator which dynamically generates classes to speed up the dynamic instantiation of objects. Since we cannot support every use case with byte code generation we gracefully fallback to the ReflectiveEntityInstantiator.