DATACMNS-406 - Tighten contract for RepositoryMetadata implementations. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare issue branch.
| this.repositoryInterface = repositoryInterface; | ||
| Assert.isTrue(Repository.class.isAssignableFrom(repositoryInterface), MUST_BE_A_REPOSITORY); | ||
|
|
||
| Class<? extends Serializable> idType = resolveIdType(repositoryInterface); |
There was a problem hiding this comment.
Could be assigned to the field directly.
We now resolve the domain- and id-types eagerly within the constructor of AbstractRepositoryMetadata implementations to prevent a RepositoryMetadata instance to be created in an invalid state. Pulled-up repositoryInterface property to AbstractRepositoryMetadata.
Refactored code in RepositoryMetadata implementations to avoid compiler warnings. Some JavaDoc polishing.
thomasdarimont
pushed a commit
that referenced
this pull request
Nov 21, 2013
We now resolve the domain and id-types eagerly within the constructor of AbstractRepositoryMetadata implementations to prevent a RepositoryMetadata instance to be created in an invalid state. Pulled-up repositoryInterface property to AbstractRepositoryMetadata. Original pull request: #58.
odrotbohm
added a commit
that referenced
this pull request
Nov 21, 2013
Refactored code in RepositoryMetadata implementations to avoid compiler warnings. Some JavaDoc polishing. Original pull request: #58.
thomasdarimont
pushed a commit
that referenced
this pull request
Nov 21, 2013
We now resolve the domain and id-types eagerly within the constructor of AbstractRepositoryMetadata implementations to prevent a RepositoryMetadata instance to be created in an invalid state. Pulled-up repositoryInterface property to AbstractRepositoryMetadata. Original pull request: #58.
odrotbohm
added a commit
that referenced
this pull request
Nov 21, 2013
Refactored code in RepositoryMetadata implementations to avoid compiler warnings. Some JavaDoc polishing. Original pull request: #58.
thomasdarimont
pushed a commit
that referenced
this pull request
Nov 22, 2013
We now resolve the domain and id-types eagerly within the constructor of AbstractRepositoryMetadata implementations to prevent a RepositoryMetadata instance to be created in an invalid state. Pulled-up repositoryInterface property to AbstractRepositoryMetadata. Original pull request: #58.
odrotbohm
added a commit
that referenced
this pull request
Nov 22, 2013
Refactored code in RepositoryMetadata implementations to avoid compiler warnings. Some JavaDoc polishing. Original pull request: #58.
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
See also the integration tests in spring-cloud-samples/tests Fixes spring-projectsgh-58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now resolve the domain- and id-types eagerly within the constructor of AbstractRepositoryMetadata implementations to prevent a RepositoryMetadata instance to be created in an invalid state.
Pulled-up repositoryInterface property to AbstractRepositoryMetadata.