Skip to content

Add the required override to the example. #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

michael-simons
Copy link
Contributor

The snipped does not compile as is. This addition makes it easier to understand what is actually required.

mp911de pushed a commit that referenced this pull request Dec 1, 2020
The example should be a compilable unit.

Original pull request: #475.
mp911de added a commit that referenced this pull request Dec 1, 2020
Consistent callout indentation. Tweak wording.

Original pull request: #475.
mp911de pushed a commit that referenced this pull request Dec 1, 2020
The example should be a compilable unit.

Original pull request: #475.
mp911de added a commit that referenced this pull request Dec 1, 2020
Consistent callout indentation. Tweak wording.

Original pull request: #475.
mp911de pushed a commit that referenced this pull request Dec 1, 2020
The example should be a compilable unit.

Original pull request: #475.
mp911de added a commit that referenced this pull request Dec 1, 2020
Consistent callout indentation. Tweak wording.

Original pull request: #475.
mp911de pushed a commit that referenced this pull request Dec 1, 2020
The example should be a compilable unit.

Original pull request: #475.
mp911de added a commit that referenced this pull request Dec 1, 2020
Consistent callout indentation. Tweak wording.

Original pull request: #475.
@mp911de
Copy link
Member

mp911de commented Dec 1, 2020

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants